Add test for showing confirmation dialog for unsecure signin

chrome/browser/ui/webui/signin/login_ui_service.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_UI_WEBUI_SIGNIN_LOGIN_UI_SERVICE_H_
 #define CHROME_BROWSER_UI_WEBUI_SIGNIN_LOGIN_UI_SERVICE_H_
 
 #include "base/basictypes.h"
 #include "base/observer_list.h"
 #include "components/keyed_service/core/keyed_service.h"
@@ skipping 17 matching lines @@
     virtual void CloseUI() = 0;
    protected:
     virtual ~LoginUI() {}
   };
 
   // Interface for obervers of LoginUIService.
   class Observer {
    public:
     // Called when a new login UI is shown.
     // |ui| The login UI that was just shown. Will never be null.
-    virtual void OnLoginUIShown(LoginUI* ui) = 0;
+    virtual void OnLoginUIShown(LoginUI* ui) {}
 
     // Called when a login UI is closed.
     // |ui| The login UI that was just closed; will never be null.
-    virtual void OnLoginUIClosed(LoginUI* ui) = 0;
+    virtual void OnLoginUIClosed(LoginUI* ui) {}
+
+    // Called when a confirmation UI for untrusted signin is shown.
+    virtual void UntrustedSigninUIShown() {}

[Roger Tawa OOO till Jul 10th, 2014/07/28 14:27:50]

Is this shown instead of or as well as OnLoginUIShown()?  Can you add
documentation?

Rename to UntrustedLoginUIShown() for consistency.

[guohui, 2014/08/07 19:53:34]

The documentation has been updated to cover all login related UIs, instead of
just login UIs.

Method renamed.

 
    protected:
     virtual ~Observer() {}
   };
 
   explicit LoginUIService(Profile* profile);
   virtual ~LoginUIService();
 
   // Gets the currently active login UI, or null if no login UI is active.
   LoginUI* current_login_ui() const {
     return ui_;
   }
 
   // |observer| The observer to add or remove; cannot be NULL.
   void AddObserver(Observer* observer);
   void RemoveObserver(Observer* observer);
 
   // Sets the currently active login UI. It is illegal to call this if there is
   // already login UI visible.
   void SetLoginUI(LoginUI* ui);
 
   // Called when login UI is closed. If the passed UI is the current login UI,
   // sets current_login_ui() to null.
   void LoginUIClosed(LoginUI* ui);
 
+  // Called when a confirmation UI for untrusted signin is shown.
+  void UntrustedSigninUIShown();

[Roger Tawa OOO till Jul 10th, 2014/07/28 14:27:50]

Rename as well.

[guohui, 2014/08/07 19:53:34]

for consistency i think we should not add On here.

+
   // Delegate to an existing login dialog if one exists.
   // If not, we make a new popup dialog window, and set it to
   // chrome://signin to ask the user to sign in to chrome.
   void ShowLoginPopup();
 
  private:
   // Weak pointer to the currently active login UI, or null if none.
   LoginUI* ui_;
   Profile* profile_;
 
   // List of observers.
   ObserverList<Observer> observer_list_;
 
   DISALLOW_COPY_AND_ASSIGN(LoginUIService);
 };
 
 #endif  // CHROME_BROWSER_UI_WEBUI_SIGNIN_LOGIN_UI_SERVICE_H_