Add test for showing confirmation dialog for unsecure signin

chrome/browser/resources/gaia_auth/background.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview
  * A background script of the auth extension that bridges the communication
  * between the main and injected scripts.
  *
  * Here is an overview of the communication flow when SAML is being used:
@@ skipping 13 matching lines @@
  */
 
 /**
  * BackgroundBridgeManager maintains an array of BackgroundBridge, indexed by
  * the associated tab id.
  */
 function BackgroundBridgeManager() {
 }
 
 BackgroundBridgeManager.prototype = {
+  CONTINUE_URL_BASE: 'chrome-extension://mfffpogegjflfpflabcdkioaeobkgjik' +
+                     '/success.html',
   // Maps a tab id to its associated BackgroundBridge.
   bridges_: {},
 
   run: function() {
     chrome.runtime.onConnect.addListener(this.onConnect_.bind(this));
 
     chrome.webRequest.onBeforeRequest.addListener(
         function(details) {
           if (this.bridges_[details.tabId])
             return this.bridges_[details.tabId].onInsecureRequest(details.url);
@@ skipping 17 matching lines @@
             this.bridges_[details.tabId].onHeadersReceived(details);
         }.bind(this),
         {urls: ['*://*/*'], types: ['sub_frame']},
         ['responseHeaders']);
 
     chrome.webRequest.onCompleted.addListener(
         function(details) {
           if (this.bridges_[details.tabId])
             this.bridges_[details.tabId].onCompleted(details);
         }.bind(this),
-        {urls: ['*://*/*'], types: ['sub_frame']},
+        {urls: ['*://*/*', this.CONTINUE_URL_BASE + '*'], types: ['sub_frame']},

[Roger Tawa OOO till Jul 10th, 2014/07/28 14:27:50]

Why append *?

[guohui, 2014/08/07 19:53:34]

we need * to match any trailing URL parameters.

         ['responseHeaders']);
   },
 
   onConnect_: function(port) {
     var tabId = this.getTabIdFromPort_(port);
     if (!this.bridges_[tabId])
       this.bridges_[tabId] = new BackgroundBridge(tabId);
     if (port.name == 'authMain') {
       this.bridges_[tabId].setupForAuthMain(port);
       port.onDisconnect.addListener(function() {
@@ skipping 20 matching lines @@
 function BackgroundBridge(tabId) {
   this.tabId_ = tabId;
 }
 
 BackgroundBridge.prototype = {
   // The associated tab ID. Only used for debugging now.
   tabId: null,
 
   isDesktopFlow_: false,
 
-  // Continue URL that is set from main auth script.
-  continueUrl_: null,
-
   // Whether the extension is loaded in a constrained window.
   // Set from main auth script.
   isConstrainedWindow_: null,
 
   // Email of the newly authenticated user based on the gaia response header
   // 'google-accounts-signin'.
   email_: null,
 
   // Session index of the newly authenticated user based on the gaia response
   // header 'google-accounts-signin'.
@@ skipping 61 matching lines @@
         'pageLoaded', this.onPageLoaded_.bind(this));
   },
 
   /**
    * Handler for 'initDesktopFlow' signal sent from the main script.
    * Only called in desktop mode.
    */
   onInitDesktopFlow_: function(msg) {
     this.isDesktopFlow_ = true;
     this.gaiaUrl_ = msg.gaiaUrl;
-    this.continueUrl_ = msg.continueUrl;
     this.isConstrainedWindow_ = msg.isConstrainedWindow;
   },
 
   /**
    * Handler for webRequest.onCompleted. It 1) detects loading of continue URL
    * and notifies the main script of signin completion; 2) detects if the
    * current page could be loaded in a constrained window and signals the main
    * script of switching to full tab if necessary.
    */
   onCompleted: function(details) {
     // Only monitors requests in the gaia frame whose parent frame ID must be
     // positive.
     if (!this.isDesktopFlow_ || details.parentFrameId <= 0)
       return;
 
-    var msg = null;
-    if (this.continueUrl_ &&
-        details.url.lastIndexOf(this.continueUrl_, 0) == 0) {
+    if (details.url.lastIndexOf(backgroundBridgeManager.CONTINUE_URL_BASE, 0) ==
+        0) {
       var skipForNow = false;
       if (details.url.indexOf('ntp=1') >= 0)
         skipForNow = true;
 
       // TOOD(guohui): Show password confirmation UI.
       var passwords = this.onGetScrapedPasswords_();
-      msg = {
+      var msg = {
         'name': 'completeLogin',
         'email': this.email_,
         'password': passwords[0],
         'sessionIndex': this.sessionIndex_,
         'skipForNow': skipForNow
       };
       this.channelMain_.send(msg);
     } else if (this.isConstrainedWindow_) {
       // The header google-accounts-embedded is only set on gaia domain.
       if (this.gaiaUrl_ && details.url.lastIndexOf(this.gaiaUrl_) == 0) {
         var headers = details.responseHeaders;
         for (var i = 0; headers && i < headers.length; ++i) {
           if (headers[i].name.toLowerCase() == 'google-accounts-embedded')
             return;
         }
       }
-      msg = {
+      var msg = {
         'name': 'switchToFullTab',
         'url': details.url
       };
       this.channelMain_.send(msg);
     }
   },
 
   /**
    * Handler for webRequest.onBeforeRequest, invoked when content served over an
    * unencrypted connection is detected. Determines whether the request should
@@ skipping 115 matching lines @@
   },
 
   onPageLoaded_: function(msg) {
     if (this.channelMain_)
       this.channelMain_.send({name: 'onAuthPageLoaded', url: msg.url});
   }
 };
 
 var backgroundBridgeManager = new BackgroundBridgeManager();
 backgroundBridgeManager.run();