Add test for showing confirmation dialog for unsecure signin

net/test/embedded_test_server/embedded_test_server.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "net/test/embedded_test_server/embedded_test_server.h"
 
 #include "base/bind.h"
 #include "base/file_util.h"
 #include "base/files/file_path.h"
 #include "base/message_loop/message_loop.h"
@@ skipping 180 matching lines @@
   if (result == OK) {
     base_url_ = GURL(std::string("http://") + address.ToString());
   } else {
     LOG(ERROR) << "GetLocalAddress failed: " << ErrorToString(result);
   }
 }
 
 void EmbeddedTestServer::ListenOnIOThread() {
   DCHECK(io_thread_->message_loop_proxy()->BelongsToCurrentThread());
   DCHECK(Started());
+
+#if !defined(OS_POSIX)
+  // Releases the socket here so that we could rebind it and watch it on the
+  // right IO thread below. An alternative is to simply call
+  // StreamListenSocket::WatchSocket, which is protected at the moment.
+  // This hack is only needed for non POSIX platforms, since on POSIX platforms
+  // StreamListenSocket::Listen calls StreamListenSocket::WatchSocket inside the
+  // function.
+  listen_socket_.reset();
+
+  SocketDescriptor socket_descriptor =
+      TCPListenSocket::CreateAndBind("127.0.0.1", port_);

[xiyuan, 2014/08/11 22:00:41]

Thank you for digging through the problem. 

Maybe we want to fix it in HttpListenSocket (this seems to be a test class
defined in this file) by calling or exposing WatchSocket. Rebinding to |port_|
would be flaky on test bots where many test servers are running and might steal
the |port_| once it is released.

[oshima, 2014/08/12 04:27:25]

sounds good to me.

If this was broken, I'm curious to know why tests were passing?

[guohui, 2014/08/12 15:55:19]

thanks xiyuan, missed that =)

i think it is because the approach of splitting into two parts has only been
implemented in CrOS tests so far.

+  if (socket_descriptor == kInvalidSocket)
+    return;
+
+  listen_socket_.reset(new HttpListenSocket(socket_descriptor, this));
+#endif
+
   listen_socket_->Listen();
 }
 
 void EmbeddedTestServer::ShutdownOnIOThread() {
   DCHECK(io_thread_->message_loop_proxy()->BelongsToCurrentThread());
 
   listen_socket_.reset();
   STLDeleteContainerPairSecondPointers(connections_.begin(),
                                        connections_.end());
   connections_.clear();
@@ skipping 116 matching lines @@
           FROM_HERE, closure, run_loop.QuitClosure())) {
     return false;
   }
   run_loop.Run();
 
   return true;
 }
 
 }  // namespace test_server
 }  // namespace net