Mac: Implement profile error dialog.

Mac: Implement profile error dialog.

The "active window" change was done for linux in http://codereview.chromium.org/147091 and might fix other problems too. Without this, BrowserList::GetLastActive() returns NULL in  Browser::Observe(), which caused the new function not to be called.

It looks something like http://imgur.com/6PHQm .

BUG=26377
TEST=
chmod -r ~/Library/Application\ Support/Chromium/Default/History*
Then start chromium (release build, so that we survive some sqlite dchecks) and make sure it displays an error message (then chmod +r again)

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=32738

[viettrungluu, 2009-11-21 07:32:38]

LGTM (aside from quibbling about very minor style details in the comment),
though you might consider asking someone else about the implications. I'm not
hugely worried though.

http://codereview.chromium.org/418040/diff/2001/2002
File chrome/browser/cocoa/browser_window_cocoa.mm (right):

http://codereview.chromium.org/418040/diff/2001/2002#newcode53
Line 53: // browser at the time Show() is called. This is the natural behaviour
under
That should be "|Show()|", I suppose.

http://codereview.chromium.org/418040/diff/2001/2002#newcode54
Line 54: // Windows, but |makeKeyAndOrderFront:| won't send
|windowDidBecomeMain:|
One day (apparently today), I'll point out that the '-' is an integral part of a
method's signature.

http://codereview.chromium.org/418040/diff/2001/2002#newcode56
Line 56: // BrowserList::GetLastActive() (for example, in bookmark_util), will
return
|...| here to.

[Nico, 2009-11-21 07:41:42]

Elliot: FYI, since you did this on Linux.