Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: mojo/system/mapping_table.cc

Issue 418033005: Mojo: Change how we handle invalid pointer arguments (at the system layer). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: review changes Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « mojo/system/mapping_table.h ('k') | mojo/system/memory.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/system/mapping_table.h" 5 #include "mojo/system/mapping_table.h"
6 6
7 #include "base/logging.h" 7 #include "base/logging.h"
8 #include "mojo/system/constants.h" 8 #include "mojo/system/constants.h"
9 #include "mojo/system/raw_shared_buffer.h" 9 #include "mojo/system/raw_shared_buffer.h"
10 10
(...skipping 15 matching lines...) Expand all
26 if (address_to_mapping_map_.size() >= kMaxMappingTableSize) 26 if (address_to_mapping_map_.size() >= kMaxMappingTableSize)
27 return MOJO_RESULT_RESOURCE_EXHAUSTED; 27 return MOJO_RESULT_RESOURCE_EXHAUSTED;
28 28
29 uintptr_t address = reinterpret_cast<uintptr_t>(mapping->base()); 29 uintptr_t address = reinterpret_cast<uintptr_t>(mapping->base());
30 DCHECK(address_to_mapping_map_.find(address) == 30 DCHECK(address_to_mapping_map_.find(address) ==
31 address_to_mapping_map_.end()); 31 address_to_mapping_map_.end());
32 address_to_mapping_map_[address] = mapping.release(); 32 address_to_mapping_map_[address] = mapping.release();
33 return MOJO_RESULT_OK; 33 return MOJO_RESULT_OK;
34 } 34 }
35 35
36 MojoResult MappingTable::RemoveMapping(void* address) { 36 MojoResult MappingTable::RemoveMapping(uintptr_t address) {
37 AddressToMappingMap::iterator it = 37 AddressToMappingMap::iterator it = address_to_mapping_map_.find(address);
38 address_to_mapping_map_.find(reinterpret_cast<uintptr_t>(address));
39 if (it == address_to_mapping_map_.end()) 38 if (it == address_to_mapping_map_.end())
40 return MOJO_RESULT_INVALID_ARGUMENT; 39 return MOJO_RESULT_INVALID_ARGUMENT;
41 RawSharedBufferMapping* mapping_to_delete = it->second; 40 RawSharedBufferMapping* mapping_to_delete = it->second;
42 address_to_mapping_map_.erase(it); 41 address_to_mapping_map_.erase(it);
43 delete mapping_to_delete; 42 delete mapping_to_delete;
44 return MOJO_RESULT_OK; 43 return MOJO_RESULT_OK;
45 } 44 }
46 45
47 } // namespace system 46 } // namespace system
48 } // namespace mojo 47 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/system/mapping_table.h ('k') | mojo/system/memory.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698