Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 418033004: Fix chrome_elf_unittests on 64 bit builds. (Closed)

Created:
6 years, 5 months ago by robertshield
Modified:
6 years, 5 months ago
Reviewers:
hans, Cait (Slow)
CC:
chromium-reviews, caitkp+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Fix chrome_elf_unittests on 64 bit builds. BUG=397137, 396244 TEST=chrome_elf_unittests NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285377

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M chrome_elf/blacklist/test/blacklist_test.cc View 1 chunk +11 lines, -1 line 0 comments Download

Messages

Total messages: 12 (0 generated)
robertshield
6 years, 5 months ago (2014-07-24 16:12:59 UTC) #1
hans
LGTM
6 years, 5 months ago (2014-07-24 16:35:37 UTC) #2
Cait (Slow)
lgtm
6 years, 5 months ago (2014-07-24 16:41:14 UTC) #3
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 5 months ago (2014-07-24 16:46:16 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/418033004/1
6 years, 5 months ago (2014-07-24 16:47:26 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 18:51:09 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 19:23:02 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/1961)
6 years, 5 months ago (2014-07-24 19:23:03 UTC) #8
hans
On 2014/07/24 19:23:03, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 5 months ago (2014-07-24 19:31:27 UTC) #9
robertshield
The CQ bit was checked by robertshield@chromium.org
6 years, 5 months ago (2014-07-24 21:15:46 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/robertshield@chromium.org/418033004/1
6 years, 5 months ago (2014-07-24 21:18:36 UTC) #11
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 21:21:43 UTC) #12
Message was sent while issue was closed.
Change committed as 285377

Powered by Google App Engine
This is Rietveld 408576698