Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(92)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417983002: [fsp] Add support for truncating files. (Closed)

Created:
6 years, 5 months ago by mtomasz
Modified:
6 years, 5 months ago
Reviewers:
benwells, hirono, kinaba
CC:
chromium-reviews, extensions-reviews_chromium.org, nkostylev+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

[fsp] Add support for truncating files. This CL adds support to truncate files to a desired length via FileWriter's truncate() method in JS. Note, that truncating via NaCl IO is not supported yet. TEST=unit_tests, browser_tests: *FileSystemProvider*Truncate* BUG=391362 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285525

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fixed. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+324 lines, -67 lines) Patch
M chrome/browser/chromeos/extensions/file_system_provider/file_system_provider_apitest.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util.cc View 2 chunks +29 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/provider_async_file_util_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/truncate.h View 3 chunks +12 lines, -10 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/truncate.cc View 2 chunks +17 lines, -14 lines 0 comments Download
A + chrome/browser/chromeos/file_system_provider/operations/truncate_unittest.cc View 4 chunks +48 lines, -39 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.h View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system.cc View 2 chunks +17 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/provided_file_system_interface.h View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.h View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/request_manager.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_browser_chromeos.gypi View 1 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M chrome/common/extensions/api/file_system_provider.idl View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/renderer/resources/extensions/file_system_provider_custom_bindings.js View 1 chunk +4 lines, -0 lines 0 comments Download
A + chrome/test/data/extensions/api_test/file_system_provider/truncate/manifest.json View 1 chunk +2 lines, -2 lines 0 comments Download
A chrome/test/data/extensions/api_test/file_system_provider/truncate/test.js View 1 1 chunk +144 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
mtomasz
@kinaba: PTAL at C++. @benwells: PTAL at IDL. @hirono: PTAL at JS. This is a ...
6 years, 5 months ago (2014-07-24 10:02:01 UTC) #1
hirono
lgtm for *.js https://codereview.chromium.org/417983002/diff/1/chrome/test/data/extensions/api_test/file_system_provider/truncate/test.js File chrome/test/data/extensions/api_test/file_system_provider/truncate/test.js (right): https://codereview.chromium.org/417983002/diff/1/chrome/test/data/extensions/api_test/file_system_provider/truncate/test.js#newcode17 chrome/test/data/extensions/api_test/file_system_provider/truncate/test.js:17: * @param {function(} onSuccess Success callback. ...
6 years, 5 months ago (2014-07-24 10:16:48 UTC) #2
kinaba
lgtm
6 years, 5 months ago (2014-07-25 01:53:36 UTC) #3
benwells
lgtm
6 years, 5 months ago (2014-07-25 04:17:48 UTC) #4
mtomasz
https://codereview.chromium.org/417983002/diff/1/chrome/test/data/extensions/api_test/file_system_provider/truncate/test.js File chrome/test/data/extensions/api_test/file_system_provider/truncate/test.js (right): https://codereview.chromium.org/417983002/diff/1/chrome/test/data/extensions/api_test/file_system_provider/truncate/test.js#newcode17 chrome/test/data/extensions/api_test/file_system_provider/truncate/test.js:17: * @param {function(} onSuccess Success callback. On 2014/07/24 10:16:48, ...
6 years, 5 months ago (2014-07-25 04:24:27 UTC) #5
mtomasz
The CQ bit was checked by mtomasz@chromium.org
6 years, 5 months ago (2014-07-25 04:24:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mtomasz@chromium.org/417983002/20001
6 years, 5 months ago (2014-07-25 04:27:21 UTC) #7
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 08:11:22 UTC) #8
Message was sent while issue was closed. 
Change committed as 285525

Powered by Google App Engine
This is Rietveld 408576698