Issue 417973003: Cleanup webkit_child target and dependencies on it.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 417973003: Cleanup webkit_child target and dependencies on it. (Closed)

Created:
6 years, 5 months ago by tfarina

Modified:
6 years, 4 months ago

Reviewers:
jamesr

CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, darin-cc_chromium.org, jam, tfarina, abarth-chromium, darin (slow to review), jochen (gone - plz use gerrit), pilgrim_google

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Cleanup webkit_child target and dependencies on it. BUG=338338 TEST=None R=jamesr@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285619

Patch Set 1 #

Patch Set 2 : fix #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -110 lines)			Patch
M	chrome/chrome_renderer.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/content_renderer.gypi	View		1 chunk	+0 lines, -1 line	0 comments	Download
M	content/content_tests.gypi	View	1	6 chunks	+1 line, -9 lines	0 comments	Download
M	ui/app_list/app_list.gyp	View		1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/child/BUILD.gn	View		1 chunk	+0 lines, -37 lines	0 comments	Download
M	webkit/child/webkit_child.gyp	View		1 chunk	+2 lines, -57 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/417973003/20001

6 years, 4 months ago (2014-07-25 16:29:24 UTC) #5

Message was sent while issue was closed.

Change committed as 285619

Expand Messages | Collapse Messages