Issue 417973002: Fix automatic tagging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 417973002: Fix automatic tagging. (Closed)

Created:
6 years, 5 months ago by Michael Achenbach

Modified:
6 years, 5 months ago

Reviewers:
Jarin

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Project:
v8

Visibility:
Public.

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+4 lines, -3 lines)			Patch
M	tools/push-to-trunk/auto_tag.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/push-to-trunk/common_includes.py	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/push-to-trunk/test_scripts.py	View	1 chunk	+2 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

Michael Achenbach

PTAL. Maybe more test coverage would have helped to catch these two... Bug 1: Missing ...

6 years, 5 months ago (2014-07-24 07:34:45 UTC) #1

Michael Achenbach

6 years, 5 months ago (2014-07-24 07:36:31 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r22580 (presubmit successful).