Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(486)

Issue 417953006: Reland r285145: Remove RendererPreferences font-rendering enums. (Closed)

Created:
6 years, 5 months ago by Daniel Erat
Modified:
6 years, 4 months ago
CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, android-webview-reviews_chromium.org, creis+watch_chromium.org, johnme
Project:
chromium
Visibility:
Public.

Description

Reland r285145: Remove RendererPreferences font-rendering enums. This reverts r285292, but avoids modifying RendererPreference::subpixel_positioning's default value, as it appears to be used by layout tests on Android. BUG=285292 TBR=msw@chromium.org,boliu@chromium.org,jln@chromium.org,jochen@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285850

Patch Set 1 #

Patch Set 2 : change RendererPreferences::use_subpixel_positioning's default back to false #

Patch Set 3 : merge again (cleanly... not sure why cq patch step is failing) #

Unified diffs Side-by-side diffs Delta from patch set Stats (+63 lines, -187 lines) Patch
M android_webview/native/aw_settings.cc View 1 2 2 chunks +2 lines, -43 lines 0 comments Download
M chrome/browser/renderer_preferences_util.cc View 1 2 2 chunks +2 lines, -47 lines 0 comments Download
M content/common/view_messages.h View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/renderer_preferences.h View 3 chunks +3 lines, -19 lines 0 comments Download
M content/public/common/renderer_preferences.cc View 1 2 chunks +3 lines, -3 lines 0 comments Download
M content/renderer/render_view_linux.cc View 2 chunks +47 lines, -69 lines 0 comments Download
M ui/gfx/font_render_params.cc View 1 2 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 17 (0 generated)
Daniel Erat
bo kindly tested this for me on android and verified that layout tests pass. i've ...
6 years, 5 months ago (2014-07-25 22:57:02 UTC) #1
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 5 months ago (2014-07-25 22:57:05 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/417953006/20001
6 years, 5 months ago (2014-07-25 22:59:03 UTC) #3
msw
lgtm
6 years, 5 months ago (2014-07-25 23:02:39 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: android_aosp on tryserver.chromium ...
6 years, 5 months ago (2014-07-26 00:09:11 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-26 00:11:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/ios_dbg_simulator/builds/174078)
6 years, 5 months ago (2014-07-26 00:11:29 UTC) #7
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 5 months ago (2014-07-26 03:00:30 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/417953006/20001
6 years, 5 months ago (2014-07-26 05:00:20 UTC) #9
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_gpu on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-26 17:12:18 UTC) #10
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-26 17:14:43 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: linux_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/44455) mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/33760) ios_dbg_simulator ...
6 years, 5 months ago (2014-07-26 17:14:44 UTC) #12
Daniel Erat
(tbr-ing more reviewers from https://codereview.chromium.org/413523004/, the previous iteration)
6 years, 4 months ago (2014-07-27 12:35:25 UTC) #13
Daniel Erat
The CQ bit was checked by derat@chromium.org
6 years, 4 months ago (2014-07-27 12:35:31 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/derat@chromium.org/417953006/40001
6 years, 4 months ago (2014-07-27 12:35:43 UTC) #15
commit-bot: I haz the power
Change committed as 285850
6 years, 4 months ago (2014-07-28 00:27:15 UTC) #16
Daniel Erat
6 years, 4 months ago (2014-07-28 14:28:56 UTC) #17
Message was sent while issue was closed.
Accidentally put the revision ID into the BUG= line. :-( It should've been
http://crbug.com/393243.

Powered by Google App Engine
This is Rietveld 408576698