Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Side by Side Diff: test/mjsunit/array-splice.js

Issue 417953004: Revert 22595: "Keep new arrays allocated with 'new Array(N)' in fast mode" (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « test/mjsunit/array-feedback.js ('k') | test/mjsunit/array-unshift.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
11 // with the distribution. 11 // with the distribution.
12 // * Neither the name of Google Inc. nor the names of its 12 // * Neither the name of Google Inc. nor the names of its
13 // contributors may be used to endorse or promote products derived 13 // contributors may be used to endorse or promote products derived
14 // from this software without specific prior written permission. 14 // from this software without specific prior written permission.
15 // 15 //
16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS 16 // THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS
17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT 17 // "AS IS" AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT
18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR 18 // LIMITED TO, THE IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR
19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT 19 // A PARTICULAR PURPOSE ARE DISCLAIMED. IN NO EVENT SHALL THE COPYRIGHT
20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL, 20 // OWNER OR CONTRIBUTORS BE LIABLE FOR ANY DIRECT, INDIRECT, INCIDENTAL,
21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT 21 // SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT NOT
22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE, 22 // LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY 23 // DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 24 // THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 25 // (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 26 // OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
27 27
28 // Flags: --allow-natives-syntax
29
30 // Check that splicing array of holes keeps it as array of holes 28 // Check that splicing array of holes keeps it as array of holes
31 (function() { 29 (function() {
32 for (var i = 0; i < 7; i++) { 30 for (var i = 0; i < 7; i++) {
33 var array = new Array(10); 31 var array = new Array(10);
34 var spliced = array.splice(1, 1, 'one', 'two'); 32 var spliced = array.splice(1, 1, 'one', 'two');
35 assertEquals(1, spliced.length); 33 assertEquals(1, spliced.length);
36 assertFalse(0 in spliced, "0 in spliced"); 34 assertFalse(0 in spliced, "0 in spliced");
37 35
38 assertEquals(11, array.length); 36 assertEquals(11, array.length);
39 assertFalse(0 in array, "0 in array"); 37 assertFalse(0 in array, "0 in array");
(...skipping 312 matching lines...) Expand 10 before | Expand all | Expand 10 after
352 assertEquals([], spliced); 350 assertEquals([], spliced);
353 assertEquals([1, 2, 3, 4], array); 351 assertEquals([1, 2, 3, 4], array);
354 } 352 }
355 })(); 353 })();
356 354
357 355
358 // Check the behaviour when approaching maximal values for length. 356 // Check the behaviour when approaching maximal values for length.
359 (function() { 357 (function() {
360 for (var i = 0; i < 7; i++) { 358 for (var i = 0; i < 7; i++) {
361 try { 359 try {
362 var a = %NormalizeElements([]); 360 new Array(Math.pow(2, 32) - 3).splice(-1, 0, 1, 2, 3, 4, 5);
363 a.length = Math.pow(2, 32) - 3;
364 a.splice(-1, 0, 1, 2, 3, 4, 5);
365 throw 'Should have thrown RangeError'; 361 throw 'Should have thrown RangeError';
366 } catch (e) { 362 } catch (e) {
367 assertTrue(e instanceof RangeError); 363 assertTrue(e instanceof RangeError);
368 } 364 }
369 365
370 // Check smi boundary 366 // Check smi boundary
371 var bigNum = (1 << 30) - 3; 367 var bigNum = (1 << 30) - 3;
372 var array = %NormalizeElements([]); 368 var array = new Array(bigNum);
373 array.length = bigNum;
374 array.splice(-1, 0, 1, 2, 3, 4, 5, 6, 7); 369 array.splice(-1, 0, 1, 2, 3, 4, 5, 6, 7);
375 assertEquals(bigNum + 7, array.length); 370 assertEquals(bigNum + 7, array.length);
376 } 371 }
377 })(); 372 })();
378 373
379 (function() { 374 (function() {
380 for (var i = 0; i < 7; i++) { 375 for (var i = 0; i < 7; i++) {
381 var a = [7, 8, 9]; 376 var a = [7, 8, 9];
382 a.splice(0, 0, 1, 2, 3, 4, 5, 6); 377 a.splice(0, 0, 1, 2, 3, 4, 5, 6);
383 assertEquals([1, 2, 3, 4, 5, 6, 7, 8, 9], a); 378 assertEquals([1, 2, 3, 4, 5, 6, 7, 8, 9], a);
384 assertFalse(a.hasOwnProperty(10), "a.hasOwnProperty(10)"); 379 assertFalse(a.hasOwnProperty(10), "a.hasOwnProperty(10)");
385 assertEquals(undefined, a[10]); 380 assertEquals(undefined, a[10]);
386 } 381 }
387 })(); 382 })();
OLDNEW
« no previous file with comments | « test/mjsunit/array-feedback.js ('k') | test/mjsunit/array-unshift.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698