Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(328)

Issue 417953004: Revert 22595: "Keep new arrays allocated with 'new Array(N)' in fast mode" (Closed)

Created:
6 years, 5 months ago by danno
Modified:
6 years, 5 months ago
Reviewers:
Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Revert 22595: "Keep new arrays allocated with 'new Array(N)' in fast mode" Due to failures in mjsunit/array-functions-prototype-misc TBR=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22601

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -91 lines) Patch
M src/elements.cc View 2 chunks +11 lines, -5 lines 0 comments Download
M src/objects.cc View 1 chunk +0 lines, -11 lines 0 comments Download
M src/runtime.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/runtime.cc View 3 chunks +6 lines, -33 lines 0 comments Download
M test/fuzz-natives/base.js View 2 chunks +1 line, -5 lines 0 comments Download
M test/mjsunit/allocation-site-info.js View 1 chunk +4 lines, -0 lines 0 comments Download
M test/mjsunit/apply.js View 3 chunks +2 lines, -6 lines 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 chunk +2 lines, -1 line 0 comments Download
M test/mjsunit/array-feedback.js View 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/array-splice.js View 3 chunks +2 lines, -7 lines 0 comments Download
M test/mjsunit/array-unshift.js View 2 chunks +2 lines, -6 lines 0 comments Download
M test/mjsunit/elements-kind.js View 1 chunk +1 line, -3 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/polymorph-arrays.js View 5 chunks +5 lines, -7 lines 0 comments Download
M test/mjsunit/regress/regress-2790.js View 1 chunk +1 line, -1 line 0 comments Download
M tools/generate-runtime-tests.py View 2 chunks +1 line, -2 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
danno
6 years, 5 months ago (2014-07-24 13:38:21 UTC) #1
Message was sent while issue was closed.
Committed patchset #1 manually as r22601 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698