Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417943005: Add navigator.sendBeacon() use counters. (Closed)

Created:
6 years, 5 months ago by sof
Modified:
6 years, 5 months ago
Reviewers:
tkent, abarth-chromium
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Add navigator.sendBeacon() use counters. Count API sendBeacon() use, and should its transmission quota be exceeded, count that too. R=tkent@chromium.org BUG= Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178903

Patch Set 1 #

Total comments: 2

Patch Set 2 : Supply argument names in decl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -24 lines) Patch
M Source/core/frame/UseCounter.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/modules/beacon/NavigatorBeacon.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/beacon/NavigatorBeacon.cpp View 1 6 chunks +13 lines, -19 lines 0 comments Download
M Source/modules/beacon/NavigatorBeacon.idl View 1 chunk +4 lines, -4 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
sof
Please take a look.
6 years, 5 months ago (2014-07-24 20:17:23 UTC) #1
tkent
lgtm https://codereview.chromium.org/417943005/diff/1/Source/modules/beacon/NavigatorBeacon.h File Source/modules/beacon/NavigatorBeacon.h (right): https://codereview.chromium.org/417943005/diff/1/Source/modules/beacon/NavigatorBeacon.h#newcode47 Source/modules/beacon/NavigatorBeacon.h:47: bool beaconResult(ExecutionContext*, bool, int); nit: It's hard to ...
6 years, 5 months ago (2014-07-25 00:11:47 UTC) #2
sof
https://codereview.chromium.org/417943005/diff/1/Source/modules/beacon/NavigatorBeacon.h File Source/modules/beacon/NavigatorBeacon.h (right): https://codereview.chromium.org/417943005/diff/1/Source/modules/beacon/NavigatorBeacon.h#newcode47 Source/modules/beacon/NavigatorBeacon.h:47: bool beaconResult(ExecutionContext*, bool, int); On 2014/07/25 00:11:47, tkent wrote: ...
6 years, 5 months ago (2014-07-25 05:29:56 UTC) #3
sof
The CQ bit was checked by sigbjornf@opera.com
6 years, 5 months ago (2014-07-25 05:30:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/417943005/20001
6 years, 5 months ago (2014-07-25 05:31:00 UTC) #5
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 06:33:34 UTC) #6
Message was sent while issue was closed. 
Change committed as 178903

Powered by Google App Engine
This is Rietveld 408576698