Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1023)

Issue 417943002: Revert of android tests: don't override DIR_MODULE (Closed)

Created:
6 years, 5 months ago by tim (not reviewing)
Modified:
6 years, 5 months ago
CC:
chromium-reviews, erikwright+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert of android tests: don't override DIR_MODULE (https://codereview.chromium.org/408063002/) Reason for revert: Need to fix components_unittests on iOS simulator (try was green, but test actually failed) Original issue's description: > android tests: don't override DIR_MODULE > > BUG= > R=brettw@chromium.org, nyquist@chromium.org, phajdan.jr@chromium.org, sky@chromium.org > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285096 TBR=nyquist@chromium.org,brettw@chromium.org,sky@chromium.org,phajdan.jr@chromium.org,jamesr@chromium.org NOTREECHECKS=true NOTRY=true BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285157

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -10 lines) Patch
M base/test/test_support_android.cc View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/common/chrome_paths.cc View 2 chunks +0 lines, -8 lines 0 comments Download
M components/url_fixer/url_fixer_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tim (not reviewing)
Created Revert of android tests: don't override DIR_MODULE
6 years, 5 months ago (2014-07-24 06:23:53 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tim@chromium.org/417943002/1
6 years, 5 months ago (2014-07-24 06:25:04 UTC) #2
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 06:27:34 UTC) #3
Message was sent while issue was closed.
Change committed as 285157

Powered by Google App Engine
This is Rietveld 408576698