Issue 417933004: Subzero: Fix a regalloc eviction bug.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 417933004: Subzero: Fix a regalloc eviction bug. (Closed)

Created:
6 years, 5 months ago by Jim Stichnoth

Modified:
6 years, 5 months ago

Reviewers:
jvoung (off chromium)

CC:
native-client-reviews_googlegroups.com

Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Visibility:
Public.

Subzero: Fix a regalloc eviction bug. We don't need/want to evict an inactive live range when it doesn't overlap with the live range currently being considered. This is especially important for Variables representing scratch registers that are killed by call instructions. These register assignments should obviously never be evicted. Note that the algorithm that computes the min-weight register to evict doesn't consider inactive and non-overlapping live ranges. BUG= https://code.google.com/p/nativeclient/issues/detail?id=3903 R=jvoung@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=68e2819

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+91 lines, -1 line)			Patch
	M	src/IceRegAlloc.cpp	View		1 chunk	+11 lines, -1 line	0 comments	Download
	A	tests_lit/llvm2ice_tests/regalloc_evict_non_overlap.ll	View	1	1 chunk	+80 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

Jim Stichnoth

6 years, 5 months ago (2014-07-24 15:48:18 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r68e2819 (presubmit successful).