Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(329)

Issue 417923003: Fix DCHECK with force-device-scale-factor switch enabled. (Closed)

Created:
6 years, 5 months ago by calamity
Modified:
6 years, 4 months ago
Reviewers:
stevenjb, oshima, sky
CC:
chromium-reviews, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, jam, penghuang+watch_chromium.org, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su, miu+watch_chromium.org, chrome-apps-syd-reviews_chromium.org, stevenjb
Base URL:
https://chromium.googlesource.com/chromium/src.git@fix_combobox_popup_positioning
Visibility:
Public.

Description

Fix DCHECK with force-device-scale-factor switch enabled. This CL fixes a DCHECK happening due to r284913. The CL changed the order of window addition which caused window properties to update in a different order. This is fixed by only running the DCHECKed code after the window is parented beneath a root window. BUG=396911 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285833

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 14 (0 generated)
calamity
6 years, 5 months ago (2014-07-24 06:29:55 UTC) #1
stevenjb
->oshima@
6 years, 5 months ago (2014-07-24 18:58:07 UTC) #2
oshima
lgtm
6 years, 5 months ago (2014-07-24 23:16:06 UTC) #3
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 5 months ago (2014-07-24 23:46:41 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/417923003/1
6 years, 5 months ago (2014-07-24 23:50:37 UTC) #5
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-25 04:33:10 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-25 04:36:55 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/chromium_presubmit/builds/82304)
6 years, 5 months ago (2014-07-25 04:36:56 UTC) #8
calamity
+sky for OWNERS.
6 years, 5 months ago (2014-07-25 05:36:15 UTC) #9
sky
LGTM
6 years, 5 months ago (2014-07-25 16:06:55 UTC) #10
calamity
The CQ bit was checked by calamity@chromium.org
6 years, 4 months ago (2014-07-27 03:46:59 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/calamity@chromium.org/417923003/1
6 years, 4 months ago (2014-07-27 03:47:22 UTC) #12
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium.win ...
6 years, 4 months ago (2014-07-27 06:37:36 UTC) #13
commit-bot: I haz the power
6 years, 4 months ago (2014-07-27 11:21:18 UTC) #14
Message was sent while issue was closed.
Change committed as 285833

Powered by Google App Engine
This is Rietveld 408576698