Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(453)

Unified Diff: scripts/slave/recipe_modules/chromium/api.py

Issue 417883002: Support proper retrying of telemetry_unittests in recipes (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/build
Patch Set: initial patch for review Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: scripts/slave/recipe_modules/chromium/api.py
diff --git a/scripts/slave/recipe_modules/chromium/api.py b/scripts/slave/recipe_modules/chromium/api.py
index 00bf95a922de7db823a6331d0929a2c6e6d2bc58..116f2a4518e9b7ca197d7f2bf713082004ce13fe 100644
--- a/scripts/slave/recipe_modules/chromium/api.py
+++ b/scripts/slave/recipe_modules/chromium/api.py
@@ -301,13 +301,14 @@ class ChromiumApi(recipe_api.RecipeApi):
env=env,
**kwargs)
- def run_telemetry_unittests(self, suffix=None, **kwargs):
+ def run_telemetry_unittests(self, suffix=None, cmd_args=None, **kwargs):
name = 'telemetry_unittests'
if suffix:
name += ' (%s)' % suffix
+ cmd_args = cmd_args or []
return self.runtest(
self.m.path['checkout'].join('tools', 'telemetry', 'run_tests'),
- args=['--browser=%s' % self.c.build_config_fs.lower()],
+ args=['--browser=%s' % self.c.build_config_fs.lower()] + cmd_args,
annotate='gtest',
name=name,
test_type='telemetry_unittests',
@@ -315,13 +316,14 @@ class ChromiumApi(recipe_api.RecipeApi):
xvfb=True,
**kwargs)
- def run_telemetry_perf_unittests(self, suffix=None, **kwargs):
+ def run_telemetry_perf_unittests(self, suffix=None, cmd_args=None, **kwargs):
name = 'telemetry_perf_unittests'
if suffix:
name += ' (%s)' % suffix
+ cmd_args = cmd_args or []
return self.runtest(
self.m.path['checkout'].join('tools', 'perf', 'run_tests'),
- args=['--browser=%s' % self.c.build_config_fs.lower()],
+ args=['--browser=%s' % self.c.build_config_fs.lower()] + cmd_args,
annotate='gtest',
name=name,
test_type='telemetry_perf_unittests',
« no previous file with comments | « no previous file | scripts/slave/recipe_modules/chromium/steps.py » ('j') | scripts/slave/recipe_modules/chromium/steps.py » ('J')

Powered by Google App Engine
This is Rietveld 408576698