Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Issue 417873003: First round of updates in response to commenting out stale expectations. (Closed)

Created:
6 years, 5 months ago by Peter Kasting
Modified:
6 years, 5 months ago
Reviewers:
haraken
CC:
blink-reviews, cbiesinger
Visibility:
Public.

Description

First round of updates in response to commenting out stale expectations. This deletes a few tests which sound like they're wrong/buggy, and requests rebaselines for a variety of others (or marks them expected-to-fail for reftests). It also restores the stale expectations for a few tests where that's the most appropriate action. BUG=7482, 23476, 243248, 243732, 338804, 378610, 396936, 396940, 396941, 396945 TEST=none TBR=haraken Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=178796

Patch Set 1 #

Patch Set 2 : Delete test #

Patch Set 3 : Accommodate recent expectations change for Win #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -404 lines) Patch
M LayoutTests/StaleTestExpectations View 6 chunks +3 lines, -33 lines 0 comments Download
M LayoutTests/TestExpectations View 1 2 2 chunks +22 lines, -1 line 0 comments Download
D LayoutTests/canvas/philip/tests/2d.imageData.object.ctor.html View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/canvas/philip/tests/2d.imageData.object.ctor-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/sub-pixel/file-upload-control-at-fractional-offset.html View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/sub-pixel/file-upload-control-at-fractional-offset-expected.html View 1 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/ietestcenter/css3/flexbox/flexbox-align-stretch-001.htm View 1 chunk +0 lines, -69 lines 0 comments Download
D LayoutTests/ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected.htm View 1 chunk +0 lines, -21 lines 0 comments Download
D LayoutTests/ietestcenter/css3/flexbox/flexbox-layout-002.htm View 1 chunk +0 lines, -61 lines 0 comments Download
D LayoutTests/ietestcenter/css3/flexbox/flexbox-layout-002-expected.htm View 1 chunk +0 lines, -35 lines 0 comments Download
D LayoutTests/ietestcenter/css3/multicolumn/column-filling-001.htm View 1 chunk +0 lines, -95 lines 0 comments Download
D LayoutTests/ietestcenter/css3/multicolumn/column-filling-001-expected.htm View 1 chunk +0 lines, -57 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Peter Kasting
Committed patchset #3 manually as r178796 (presubmit successful).
6 years, 5 months ago (2014-07-24 00:58:18 UTC) #1
haraken
LGTM
6 years, 5 months ago (2014-07-24 01:05:15 UTC) #2
Stephen White
Just FYI, the canvas/philip tests are imported from an upstream test suite, so the deleted ...
6 years, 5 months ago (2014-07-24 02:42:02 UTC) #3
Peter Kasting
6 years, 5 months ago (2014-07-24 03:07:27 UTC) #4
Message was sent while issue was closed.
On 2014/07/24 02:42:02, Stephen White wrote:
> Just FYI, the canvas/philip tests are imported from an upstream test suite, so
> the deleted tests may reappear when we update our copy of that suite.

Yeah, I checked with dpranke before this because I was worried about precisely
that; he said to go ahead and delete these, and that we were unlikely to update
our copy again anyway.  (The README says that suite was last updated in 2010,
IIRC.)

I'm sure if we ever do re-update we'll see that the test fails (if applicable)
at the time that happens.

Powered by Google App Engine
This is Rietveld 408576698