Issue 417843004: Remove (Set)IsBeingReloaded from ExtensionService.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 417843004: Remove (Set)IsBeingReloaded from ExtensionService. (Closed)

Created:
6 years, 5 months ago by benwells

Modified:
6 years, 5 months ago

Reviewers:
Yoyo Zhou

CC:
chromium-reviews, chromium-apps-reviews_chromium.org, extensions-reviews_chromium.org, chrome-apps-syd-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Remove (Set)IsBeingReloaded from ExtensionService. This was only used by the background mode manager, and didn't actually do what it needed. Now background mode manager doesn't use this so it can be removed. BUG=361637 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285417

Patch Set 1 #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -28 lines)			Patch
	M	chrome/browser/extensions/extension_service.h	View		2 chunks	+0 lines, -10 lines	0 comments	Download
	M	chrome/browser/extensions/extension_service.cc	View		3 chunks	+0 lines, -18 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/benwells@chromium.org/417843004/1

6 years, 5 months ago (2014-07-24 23:06:55 UTC) #4

Message was sent while issue was closed.

Change committed as 285417

Expand Messages | Collapse Messages