Make Surface::GetEligibleFrame const

Make Surface::GetEligibleFrame const

The frame shouldn't be modified by the aggregator, or else it will be broken if GetEligibleFrame is called again.
Also modify ScopedPtrVector::const_iterator to make it const-correct.

BUG=

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285431

[jamesr, 2014-07-24 19:55:48]

https://codereview.chromium.org/417843003/diff/20001/cc/base/scoped_ptr_vector.h
File cc/base/scoped_ptr_vector.h (right):

https://codereview.chromium.org/417843003/diff/20001/cc/base/scoped_ptr_vecto...
cc/base/scoped_ptr_vector.h:25: typedef typename
std::vector<T*>::const_reverse_iterator
this one too?

https://codereview.chromium.org/417843003/diff/20001/cc/surfaces/surface_aggr...
File cc/surfaces/surface_aggregator.cc (right):

https://codereview.chromium.org/417843003/diff/20001/cc/surfaces/surface_aggr...
cc/surfaces/surface_aggregator.cc:102:
RenderPass::CopyAll(frame_data->render_pass_list, render_pass_list);
why do we need this copy?

[jbauman, 2014-07-24 20:02:29]

On 2014/07/24 19:55:48, jamesr wrote:
>
https://codereview.chromium.org/417843003/diff/20001/cc/base/scoped_ptr_vector.h
> File cc/base/scoped_ptr_vector.h (right):
> 
>
https://codereview.chromium.org/417843003/diff/20001/cc/base/scoped_ptr_vecto...
> cc/base/scoped_ptr_vector.h:25: typedef typename
> std::vector<T*>::const_reverse_iterator
> this one too?
> 
>
https://codereview.chromium.org/417843003/diff/20001/cc/surfaces/surface_aggr...
> File cc/surfaces/surface_aggregator.cc (right):
> 
>
https://codereview.chromium.org/417843003/diff/20001/cc/surfaces/surface_aggr...
> cc/surfaces/surface_aggregator.cc:102:
> RenderPass::CopyAll(frame_data->render_pass_list, render_pass_list);
> why do we need this copy?

IterateResources on the quads in the render passes modifies the resource id, so
we need to make a mutable copy of the list. Should I make the copy somewhere
else?

[jamesr, 2014-07-24 20:03:46]

ah, right. lgtm then

[jbauman, 2014-07-24 20:32:04]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-07-24 20:36:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbauman@chromium.org/417843003/20001

[commit-bot: I haz the power, 2014-07-24 21:45:57]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[commit-bot: I haz the power, 2014-07-24 22:27:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-07-24 22:27:07]

Try jobs failed on following builders:
  linux_chromium_rel_swarming on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_sw...)

[jbauman, 2014-07-25 00:13:13]

The CQ bit was checked by jbauman@chromium.org

[commit-bot: I haz the power, 2014-07-25 00:17:41]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/jbauman@chromium.org/417843003/20001

[commit-bot: I haz the power, 2014-07-25 00:21:47]

Change committed as 285431