Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417843002: Update isolate file for sync_integration_tests and enable swarming for it. (Closed)

Created:
6 years, 5 months ago by jam
Modified:
6 years, 5 months ago
Reviewers:
M-A Ruel, sky
CC:
chromium-reviews
Project:
chromium
Visibility:
Public.

Description

Update isolate file for sync_integration_tests and enable swarming for it. TBR=sky Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285246

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+32 lines, -19 lines) Patch
M build/all.gyp View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/sync_integration_tests.isolate View 1 2 chunks +24 lines, -16 lines 1 comment Download
M testing/buildbot/chromium_trybot.json View 1 2 1 chunk +7 lines, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
jam
6 years, 5 months ago (2014-07-24 04:05:05 UTC) #1
M-A Ruel
lgtm
6 years, 5 months ago (2014-07-24 04:34:56 UTC) #2
jam
The CQ bit was checked by jam@chromium.org
6 years, 5 months ago (2014-07-24 05:32:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jam@chromium.org/417843002/80001
6 years, 5 months ago (2014-07-24 05:34:07 UTC) #4
jam
6 years, 5 months ago (2014-07-24 05:35:51 UTC) #5
commit-bot: I haz the power
Change committed as 285246
6 years, 5 months ago (2014-07-24 14:14:20 UTC) #6
Vadim Sh.
On 2014/07/24 14:14:20, I haz the power (commit-bot) wrote: > Change committed as 285246 I ...
6 years, 5 months ago (2014-07-24 18:24:23 UTC) #7
M-A Ruel
lgtm https://codereview.chromium.org/417843002/diff/80001/chrome/sync_integration_tests.isolate File chrome/sync_integration_tests.isolate (right): https://codereview.chromium.org/417843002/diff/80001/chrome/sync_integration_tests.isolate#newcode50 chrome/sync_integration_tests.isolate:50: 'command': [ This one needs to be moved ...
6 years, 5 months ago (2014-07-24 20:29:07 UTC) #8
M-A Ruel
On 2014/07/24 20:29:07, M-A Ruel wrote: > lgtm That was a misclick. :)
6 years, 5 months ago (2014-07-24 20:29:29 UTC) #9
jabdelmalek
6 years, 5 months ago (2014-07-24 20:36:36 UTC) #10
Message was sent while issue was closed. 
ah, sorry about that. since all win swarm jobs were failing for other reasons
yesterday, i couldn't see this.

Powered by Google App Engine
This is Rietveld 408576698