Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 417813002: Add WiFi remembered network count metric (Closed)

Created:
6 years, 5 months ago by Paul Stewart
Modified:
6 years, 5 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews, asvitkine+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 4

Patch Set 2 : Cleaned up double double and explained when profiles load #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M tools/metrics/histograms/histograms.xml View 1 chunk +10 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Paul Stewart
6 years, 5 months ago (2014-07-25 06:27:55 UTC) #1
Ilya Sherman
https://codereview.chromium.org/417813002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/417813002/diff/1/tools/metrics/histograms/histograms.xml#newcode17853 tools/metrics/histograms/histograms.xml:17853: + networks known by the connection connection manager at ...
6 years, 5 months ago (2014-07-25 17:36:59 UTC) #2
Paul Stewart
Thanks. PTAL. https://codereview.chromium.org/417813002/diff/1/tools/metrics/histograms/histograms.xml File tools/metrics/histograms/histograms.xml (right): https://codereview.chromium.org/417813002/diff/1/tools/metrics/histograms/histograms.xml#newcode17853 tools/metrics/histograms/histograms.xml:17853: + networks known by the connection connection ...
6 years, 5 months ago (2014-07-25 17:58:58 UTC) #3
Ilya Sherman
LGTM, thanks.
6 years, 5 months ago (2014-07-25 20:00:57 UTC) #4
Paul Stewart
The CQ bit was checked by pstew@chromium.org
6 years, 5 months ago (2014-07-25 21:21:51 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/pstew@chromium.org/417813002/20001
6 years, 5 months ago (2014-07-25 21:23:48 UTC) #6
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 22:54:12 UTC) #7
Message was sent while issue was closed.
Change committed as 285714

Powered by Google App Engine
This is Rietveld 408576698