Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(319)

Side by Side Diff: test/mjsunit/es7/object-observe.js

Issue 417793002: Fix issue with setters and their holders in accessors.cc (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Cleanup SetFunctionPrototype as well Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/accessors.cc ('k') | test/mjsunit/regress/regress-3462.js » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 1667 matching lines...) Expand 10 before | Expand all | Expand 10 after
1678 { object: fun, name: 'prototype', type: 'update', oldValue: 7 }, 1678 { object: fun, name: 'prototype', type: 'update', oldValue: 7 },
1679 ]); 1679 ]);
1680 1680
1681 // Function.prototype should not be observable except on the object itself 1681 // Function.prototype should not be observable except on the object itself
1682 reset(); 1682 reset();
1683 var fun = function(){}; 1683 var fun = function(){};
1684 var obj = { __proto__: fun }; 1684 var obj = { __proto__: fun };
1685 Object.observe(obj, observer.callback); 1685 Object.observe(obj, observer.callback);
1686 obj.prototype = 7; 1686 obj.prototype = 7;
1687 Object.deliverChangeRecords(observer.callback); 1687 Object.deliverChangeRecords(observer.callback);
1688 observer.assertNotCalled(); 1688 observer.assertRecordCount(1);
1689 1689 observer.assertCallbackRecords([
1690 { object: obj, name: 'prototype', type: 'add' },
1691 ]);
1690 1692
1691 // Check that changes in observation status are detected in all IC states and 1693 // Check that changes in observation status are detected in all IC states and
1692 // in optimized code, especially in cases usually using fast elements. 1694 // in optimized code, especially in cases usually using fast elements.
1693 var mutation = [ 1695 var mutation = [
1694 "a[i] = v", 1696 "a[i] = v",
1695 "a[i] ? ++a[i] : a[i] = v", 1697 "a[i] ? ++a[i] : a[i] = v",
1696 "a[i] ? a[i]++ : a[i] = v", 1698 "a[i] ? a[i]++ : a[i] = v",
1697 "a[i] ? a[i] += 1 : a[i] = v", 1699 "a[i] ? a[i] += 1 : a[i] = v",
1698 "a[i] ? a[i] -= -1 : a[i] = v", 1700 "a[i] ? a[i] -= -1 : a[i] = v",
1699 ]; 1701 ];
(...skipping 88 matching lines...) Expand 10 before | Expand all | Expand 10 after
1788 for (var n1 = 0; n1 < 3; ++n1) 1790 for (var n1 = 0; n1 < 3; ++n1)
1789 for (var n2 = 0; n2 < 3; ++n2) 1791 for (var n2 = 0; n2 < 3; ++n2)
1790 for (var i in mutation) 1792 for (var i in mutation)
1791 TestFastElementsLength(mutation[i], b1 != 0, b2 != 0, 20*n1, 20*n2); 1793 TestFastElementsLength(mutation[i], b1 != 0, b2 != 0, 20*n1, 20*n2);
1792 1794
1793 for (var b1 = 0; b1 < 2; ++b1) 1795 for (var b1 = 0; b1 < 2; ++b1)
1794 for (var b2 = 0; b2 < 2; ++b2) 1796 for (var b2 = 0; b2 < 2; ++b2)
1795 for (var n = 0; n < 3; ++n) 1797 for (var n = 0; n < 3; ++n)
1796 for (var i in mutationByIncr) 1798 for (var i in mutationByIncr)
1797 TestFastElementsLength(mutationByIncr[i], b1 != 0, b2 != 0, 7*n, 7*n+1); 1799 TestFastElementsLength(mutationByIncr[i], b1 != 0, b2 != 0, 7*n, 7*n+1);
OLDNEW
« no previous file with comments | « src/accessors.cc ('k') | test/mjsunit/regress/regress-3462.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698