Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 417793002: Fix issue with setters and their holders in accessors.cc (Closed)

Created:
6 years, 5 months ago by arv (Not doing code reviews)
Modified:
6 years, 5 months ago
Reviewers:
adamk, Toon Verwaest
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Fix issue with setters and their holders in accessors.cc BUG=3462 LOG=Y R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22606

Patch Set 1 #

Patch Set 2 : Cleanup SetFunctionPrototype as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -37 lines) Patch
M src/accessors.cc View 1 8 chunks +35 lines, -35 lines 0 comments Download
M test/mjsunit/es7/object-observe.js View 1 chunk +4 lines, -2 lines 0 comments Download
A test/mjsunit/regress/regress-3462.js View 1 chunk +48 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
arv (Not doing code reviews)
PTAL
6 years, 5 months ago (2014-07-23 20:38:43 UTC) #1
arv (Not doing code reviews)
Cleanup SetFunctionPrototype as well
6 years, 5 months ago (2014-07-23 20:50:30 UTC) #2
arv (Not doing code reviews)
Adding Adam to look at the O.o related changes.
6 years, 5 months ago (2014-07-23 20:51:32 UTC) #3
adamk
object-observe test looks good to me, I'll leave accessors.cc for verwaest
6 years, 5 months ago (2014-07-23 21:00:46 UTC) #4
Toon Verwaest
lgtm
6 years, 5 months ago (2014-07-23 21:13:49 UTC) #5
arv (Not doing code reviews)
On 2014/07/23 at 21:13:49, verwaest wrote: > lgtm Would you mind landing this for me? ...
6 years, 5 months ago (2014-07-24 15:42:52 UTC) #6
Toon Verwaest
Committed patchset #2 manually as r22606 (presubmit successful).
6 years, 5 months ago (2014-07-24 16:43:02 UTC) #7
arv (Not doing code reviews)
6 years, 5 months ago (2014-07-24 16:43:44 UTC) #8
Message was sent while issue was closed.
Thanks

Powered by Google App Engine
This is Rietveld 408576698