Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 417763002: [NaCl SDK] Silence objdump warning when building w/ Chrome dev/beta. (Closed)

Created:
6 years, 5 months ago by binji
Modified:
6 years, 5 months ago
Reviewers:
Sam Clegg
CC:
chromium-reviews, binji+watch_chromium.org, Sam Clegg
Project:
chromium
Visibility:
Public.

Description

[NaCl SDK] Silence objdump warning when building w/ Chrome dev/beta. objdump was failing when running beta or dev branch of Chrome, because the filename is now google-chrome-beta or google-chrome-dev. The code in getos.py was only checking for google-chrome. BUG=none R=sbc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285312

Patch Set 1 #

Total comments: 2

Patch Set 2 : . #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M native_client_sdk/src/tools/getos.py View 1 1 chunk +9 lines, -1 line 1 comment Download

Messages

Total messages: 5 (0 generated)
binji
6 years, 5 months ago (2014-07-23 19:56:10 UTC) #1
Sam Clegg
lgtm https://codereview.chromium.org/417763002/diff/1/native_client_sdk/src/tools/getos.py File native_client_sdk/src/tools/getos.py (right): https://codereview.chromium.org/417763002/diff/1/native_client_sdk/src/tools/getos.py#newcode150 native_client_sdk/src/tools/getos.py:150: chrome_path = os.path.join(os.path.dirname(chrome_path), 'chrome') Can we also check ...
6 years, 5 months ago (2014-07-23 19:57:44 UTC) #2
binji
https://codereview.chromium.org/417763002/diff/1/native_client_sdk/src/tools/getos.py File native_client_sdk/src/tools/getos.py (right): https://codereview.chromium.org/417763002/diff/1/native_client_sdk/src/tools/getos.py#newcode150 native_client_sdk/src/tools/getos.py:150: chrome_path = os.path.join(os.path.dirname(chrome_path), 'chrome') On 2014/07/23 19:57:44, Sam Clegg ...
6 years, 5 months ago (2014-07-23 20:58:28 UTC) #3
Sam Clegg
https://codereview.chromium.org/417763002/diff/20001/native_client_sdk/src/tools/getos.py File native_client_sdk/src/tools/getos.py (right): https://codereview.chromium.org/417763002/diff/20001/native_client_sdk/src/tools/getos.py#newcode157 native_client_sdk/src/tools/getos.py:157: I was thinking we of doing this before we ...
6 years, 5 months ago (2014-07-23 21:11:49 UTC) #4
binji
6 years, 5 months ago (2014-07-24 17:36:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 manually as r285312 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698