Add scripts to semi-automate publishing of ChromeVox webstore extension using webstore API.

Add scripts to semi-automate publishing of ChromeVox webstore extension using webstore API.

TEST=manually run through release workflow and verify api endpoints return success.
BUG=none

Committed: https://crrev.com/622b0d07837e8b4d5eb4bba379f988d2a37f9cca
Cr-Commit-Position: refs/heads/master@{#292021}

[David Tseng, 2014-07-23 18:38:07]

Still w.i.p. but as I've written minimal python (in Chrome), figured I'd send
out early.

[dmazzoni, 2014-07-23 18:52:42]

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/tools/webstore.py (right):

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore.py:1: #!/usr/bin/env
python
Maybe call this upload_to_webstore or something along those lines?

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore.py:7: '''Publishes an
extension to the webstore.
Is this "an extension" or is it just ChromeVox?

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore.py:44: new =
os.path.join('/tmp', old)
Use a tmpfile api to get a temporary file that won't accidentally overwrite
anything and will clean up when done

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/tools/webstore_util.py (right):

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore_util.py:19:
'client_secret': 'A9OhIdmTcUX9zdvRINwySHol',
Is this something we can safely check in?

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore_util.py:36: '
https://accounts.google.com/o/oauth2/auth?'
Put this url in a constant at the top

[David Tseng, 2014-07-23 22:45:31]

PTAL; uploading works now as well.

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/tools/webstore.py (right):

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore.py:1: #!/usr/bin/env
python
On 2014/07/23 18:52:41, dmazzoni wrote:
> Maybe call this upload_to_webstore or something along those lines?

I didn't specialize it because it will also contain upload/publish/publish
dogfood options.

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore.py:7: '''Publishes an
extension to the webstore.
On 2014/07/23 18:52:41, dmazzoni wrote:
> Is this "an extension" or is it just ChromeVox?

Done.

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore.py:44: new =
os.path.join('/tmp', old)
On 2014/07/23 18:52:41, dmazzoni wrote:
> Use a tmpfile api to get a temporary file that won't accidentally overwrite
> anything and will clean up when done
> 

Done.

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/tools/webstore_util.py (right):

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore_util.py:19:
'client_secret': 'A9OhIdmTcUX9zdvRINwySHol',
On 2014/07/23 18:52:42, dmazzoni wrote:
> Is this something we can safely check in?

Not sure, but it's sent in the clear as a GET query parameter.

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore_util.py:36: '
https://accounts.google.com/o/oauth2/auth?'
On 2014/07/23 18:52:42, dmazzoni wrote:
> Put this url in a constant at the top

Done.

[David Tseng, 2014-07-23 23:02:50]

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/chromevox/tools/webstore_util.py (right):

https://codereview.chromium.org/417703002/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/chromevox/tools/webstore_util.py:19:
'client_secret': 'A9OhIdmTcUX9zdvRINwySHol',
On 2014/07/23 22:45:31, David Tseng wrote:
> On 2014/07/23 18:52:42, dmazzoni wrote:
> > Is this something we can safely check in?
> 
> Not sure, but it's sent in the clear as a GET query parameter.

I take that back; it's sent as a body of a post message so I've removed this.

[dmazzoni, 2014-07-28 05:29:08]

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi (right):

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi:21: 'key':
'MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDltVl1k15pjRzuZfMc3B69inxwm2bZeZ2O8/zFO+NluHnBm3GJ3fzdOoFGJd+M16I8p7zxxQyHeDMfWYASyCeB8XnUEDKjqNLQfCnncsANzHsYoEbYj2nEUML2P13b9q+AAvpCBpAJ4cZp81e9n1y/vbSXHE4385cgkKueItzikQIDAQAB',
I'm worried about this too - wouldn't this allow anyone to publish ChromeVox or
possibly compromise it? Or is this just the key for the built-in extension, not
the web-store one?

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py
(right):

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:21:
'937534751394-gbj5334v9144c57qjqghl7d283plj5r4.apps.googleusercontent.com',
nit: 4-space indent for line continuation?

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:50:
'response_type=code&',
How about something like this to aid readability:

query = '&'.join([
    'response_type=code',
    'scope=%s' % WEBSTORE_API_SCOPE,
   ...]
auth_url = 'https://%s%s?%s' % (OAUTH_DOMAIN, OAUTH_AUTH_COMMAND, query)

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:109:
curl_command = ''.join(['curl ',
I think ' '.join with no spaces in the arguments would be more clear.

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:111:
'-H "x-goog-api-version: 2" ',
nit: line up with previous line, and below

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:117:
os.system(curl_command)
Return the result of this system call or throw if it's nonzero?

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py
(right):

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py:79:
# TODO(dtseng): Publish to webstore
Is this TODO still valid? Your comment on the code review thread says this
uploads to the web store now...

[David Tseng, 2014-07-29 21:59:24]

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi (right):

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi:21: 'key':
'MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDltVl1k15pjRzuZfMc3B69inxwm2bZeZ2O8/zFO+NluHnBm3GJ3fzdOoFGJd+M16I8p7zxxQyHeDMfWYASyCeB8XnUEDKjqNLQfCnncsANzHsYoEbYj2nEUML2P13b9q+AAvpCBpAJ4cZp81e9n1y/vbSXHE4385cgkKueItzikQIDAQAB',
On 2014/07/28 05:29:07, dmazzoni wrote:
> I'm worried about this too - wouldn't this allow anyone to publish ChromeVox
or
> possibly compromise it? Or is this just the key for the built-in extension,
not
> the web-store one?
> 

It's the built-in key (the one that's already checked into the existing
manifest). The only reason I'm adding this flag is because the webstore version
removes the key.

[dmazzoni, 2014-07-29 23:06:11]

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
File chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi (right):

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/generate_manifest.gypi:21: 'key':
'MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQDltVl1k15pjRzuZfMc3B69inxwm2bZeZ2O8/zFO+NluHnBm3GJ3fzdOoFGJd+M16I8p7zxxQyHeDMfWYASyCeB8XnUEDKjqNLQfCnncsANzHsYoEbYj2nEUML2P13b9q+AAvpCBpAJ4cZp81e9n1y/vbSXHE4385cgkKueItzikQIDAQAB',
On 2014/07/29 21:59:23, David Tseng wrote:
> On 2014/07/28 05:29:07, dmazzoni wrote:
> > I'm worried about this too - wouldn't this allow anyone to publish ChromeVox
> or
> > possibly compromise it? Or is this just the key for the built-in extension,
> not
> > the web-store one?
> > 
> 
> It's the built-in key (the one that's already checked into the existing
> manifest). The only reason I'm adding this flag is because the webstore
version
> removes the key.

Add a comment saying "Key for ChromeVox component extension in ChromeVox"?

[David Tseng, 2014-07-29 23:52:19]

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py
(right):

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:21:
'937534751394-gbj5334v9144c57qjqghl7d283plj5r4.apps.googleusercontent.com',
On 2014/07/28 05:29:07, dmazzoni wrote:
> nit: 4-space indent for line continuation?

Done.

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:50:
'response_type=code&',
On 2014/07/28 05:29:07, dmazzoni wrote:
> How about something like this to aid readability:
> 
> query = '&'.join([
>     'response_type=code',
>     'scope=%s' % WEBSTORE_API_SCOPE,
>    ...]
> auth_url = 'https://%s%s?%s' % (OAUTH_DOMAIN, OAUTH_AUTH_COMMAND, query)
> 

Done.

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:109:
curl_command = ''.join(['curl ',
On 2014/07/28 05:29:07, dmazzoni wrote:
> I think ' '.join with no spaces in the arguments would be more clear.

Done.

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:111:
'-H "x-goog-api-version: 2" ',
On 2014/07/28 05:29:07, dmazzoni wrote:
> nit: line up with previous line, and below

Done.

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:117:
os.system(curl_command)
On 2014/07/28 05:29:07, dmazzoni wrote:
> Return the result of this system call or throw if it's nonzero?

Done.

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
File
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py
(right):

https://codereview.chromium.org/417703002/diff/80001/chrome/browser/resources...
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py:79:
# TODO(dtseng): Publish to webstore
On 2014/07/28 05:29:07, dmazzoni wrote:
> Is this TODO still valid? Your comment on the code review thread says this
> uploads to the web store now...

Done.

[dmazzoni, 2014-07-30 05:39:55]

lgtm

only one serious issue - RunInteractivePrompt looks like it's inside a loop
instead of outside, but otherwise just a few last nits

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py
(right):

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:9:
import os
nit: sort these

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:21:
'client_id': ('937534751394-gbj5334v9144c57qjqghl7d283plj5r4.apps.googleuserc'
nit: maybe start the string on the next line and then it fits all on one line,
but if not, try to not break it in the middle of the domain name, like maybe put
'.apps.googleusercontent.com' on the second line.

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:112:
'-H "Authorization: %(Authorization)s"' % header,
nit: indent by one more space (and below)

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:119:
if os.system(curl_command) != 0:
Maybe print the curl command before executing it to aid in debugging if it
returns an error

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py
(right):

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py:91:
for file in files:
file is a reserved word in python, please use something else

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py:104:
RunInteractivePrompt(client_secret, output_path)
I don't think this is indented correctly - it will call this once per file

[David Tseng, 2014-07-31 21:52:57]

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py
(right):

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:9:
import os
On 2014/07/30 05:39:55, dmazzoni wrote:
> nit: sort these

Done.

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:21:
'client_id': ('937534751394-gbj5334v9144c57qjqghl7d283plj5r4.apps.googleuserc'
On 2014/07/30 05:39:55, dmazzoni wrote:
> nit: maybe start the string on the next line and then it fits all on one line,
> but if not, try to not break it in the middle of the domain name, like maybe
put
> '.apps.googleusercontent.com' on the second line.

Done.

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:112:
'-H "Authorization: %(Authorization)s"' % header,
On 2014/07/30 05:39:55, dmazzoni wrote:
> nit: indent by one more space (and below)

Done.

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/chromevox_webstore_util.py:119:
if os.system(curl_command) != 0:
On 2014/07/30 05:39:55, dmazzoni wrote:
> Maybe print the curl command before executing it to aid in debugging if it
> returns an error

Done.

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
File
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py
(right):

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py:91:
for file in files:
On 2014/07/30 05:39:55, dmazzoni wrote:
> file is a reserved word in python, please use something else

Ah yes; changed.

https://codereview.chromium.org/417703002/diff/160001/chrome/browser/resource...
chrome/browser/resources/chromeos/chromevox/tools/upload_chromevox_to_webstore.py:104:
RunInteractivePrompt(client_secret, output_path)
On 2014/07/30 05:39:55, dmazzoni wrote:
> I don't think this is indented correctly - it will call this once per file

Yup; you're right. I haven't really tested this extensively (I'm waiting on the
voices changed cl to lamek it to lkcr to exercise everything). Moved to 4 space
indent.

[David Tseng, 2014-08-26 21:09:30]

The CQ bit was checked by dtseng@chromium.org

[commit-bot: I haz the power, 2014-08-26 21:11:19]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dtseng@chromium.org/417703002/180001

[commit-bot: I haz the power, 2014-08-26 22:46:49]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[commit-bot: I haz the power, 2014-08-26 23:10:38]

Committed patchset #10 (180001) as c70990e64883f46a1d72a042f95b408836ba8084

[commit-bot: I haz the power, 2014-09-10 02:47:02]

Patchset 10 (id:??) landed as
https://crrev.com/622b0d07837e8b4d5eb4bba379f988d2a37f9cca
Cr-Commit-Position: refs/heads/master@{#292021}