Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 417683003: Remove now unnecessary const_casts. (Closed)

Created:
6 years, 5 months ago by davidben
Modified:
6 years, 5 months ago
Reviewers:
eroman
CC:
chromium-reviews, darin-cc_chromium.org, cbentzel+watch_chromium.org, jam
Project:
chromium
Visibility:
Public.

Description

Remove now unnecessary const_casts. BoringSSL fixes this API to be const-correct. BUG=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285134

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -5 lines) Patch
M content/child/webcrypto/openssl/rsa_ssa_openssl.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/cert/ct_log_verifier_openssl.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 10 (0 generated)
davidben
6 years, 5 months ago (2014-07-23 19:32:38 UTC) #1
eroman
lgtm
6 years, 5 months ago (2014-07-23 19:45:49 UTC) #2
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-23 19:46:55 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/417683003/1
6 years, 5 months ago (2014-07-23 19:48:14 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...
6 years, 5 months ago (2014-07-24 01:18:59 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 01:54:00 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_gpu_triggered_tests on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu_triggered_tests/builds/31888)
6 years, 5 months ago (2014-07-24 01:54:01 UTC) #7
davidben
The CQ bit was checked by davidben@chromium.org
6 years, 5 months ago (2014-07-24 02:53:37 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/davidben@chromium.org/417683003/1
6 years, 5 months ago (2014-07-24 02:56:47 UTC) #9
commit-bot: I haz the power
6 years, 5 months ago (2014-07-24 03:01:15 UTC) #10
Message was sent while issue was closed. 
Change committed as 285134

Powered by Google App Engine
This is Rietveld 408576698