Issue 417653004: Lower the select instruction when the operands are of vector type.

Issue 417653004: Lower the select instruction when the operands are of vector type. (Closed)

Created:
6 years, 5 months ago by wala

Modified:
6 years, 5 months ago

Reviewers:
jvoung (off chromium), Jim Stichnoth

CC:
native-client-reviews_googlegroups.com

Base URL:
https://gerrit.chromium.org/gerrit/p/native_client/pnacl-subzero.git@master

Visibility:
Public.

More Reviews

Description

Lower the select instruction when the operands are of vector type. Select of vectors is implemented by appropriately masking and combining the inputs with sign extend / bitwise operations and without the use of branches. BUG=none R=jvoung@chromium.org, stichnot@chromium.org Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=9cb61e2

Patch Set 2 : Improve comments #

Total comments: 4

Patch Set 3 : Address Jim's comments #

Total comments: 2

Patch Set 4 : Grammar #

Created: 6 years, 5 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+413 lines, -5 lines)			Patch
M	crosstest/runtests.sh	View		2 chunks	+8 lines, -0 lines	0 comments	Download
A	crosstest/test_select.h	View		1 chunk	+26 lines, -0 lines	0 comments	Download
A	crosstest/test_select.ll	View		1 chunk	+80 lines, -0 lines	0 comments	Download
A	crosstest/test_select_main.cpp	View	1 2	1 chunk	+168 lines, -0 lines	0 comments	Download
M	src/IceInst.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download
M	src/IceInstX8632.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	src/IceInstX8632.cpp	View		1 chunk	+1 line, -0 lines	0 comments	Download
M	src/IceTargetLoweringX8632.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	src/IceTargetLoweringX8632.cpp	View	1 2	3 chunks	+39 lines, -4 lines	0 comments	Download
A	tests_lit/llvm2ice_tests/vector-select.ll	View	1 2 3	1 chunk	+85 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Jim Stichnoth

LGTM with a couple of nits. https://codereview.chromium.org/417653004/diff/20001/crosstest/test_select_main.cpp File crosstest/test_select_main.cpp (right): https://codereview.chromium.org/417653004/diff/20001/crosstest/test_select_main.cpp#newcode62 crosstest/test_select_main.cpp:62: << ", Value2=" ...

6 years, 5 months ago (2014-07-23 20:06:37 UTC) #2

wala

https://codereview.chromium.org/417653004/diff/20001/crosstest/test_select_main.cpp File crosstest/test_select_main.cpp (right): https://codereview.chromium.org/417653004/diff/20001/crosstest/test_select_main.cpp#newcode62 crosstest/test_select_main.cpp:62: << ", Value2=" << vectAsString<T>(Value2) << ")" << std::endl; ...

6 years, 5 months ago (2014-07-23 20:49:54 UTC) #3

jvoung (off chromium)

LGTM https://codereview.chromium.org/417653004/diff/40001/tests_lit/llvm2ice_tests/vector-select.ll File tests_lit/llvm2ice_tests/vector-select.ll (right): https://codereview.chromium.org/417653004/diff/40001/tests_lit/llvm2ice_tests/vector-select.ll#newcode1 tests_lit/llvm2ice_tests/vector-select.ll:1: ; This file test support for the select ...

6 years, 5 months ago (2014-07-24 16:40:58 UTC) #4

wala

Committed patchset #4 manually as r9cb61e2 (presubmit successful).

6 years, 5 months ago (2014-07-24 16:44:45 UTC) #5

wala

6 years, 5 months ago (2014-07-24 16:45:16 UTC) #6

Message was sent while issue was closed.

https://codereview.chromium.org/417653004/diff/40001/tests_lit/llvm2ice_tests...
File tests_lit/llvm2ice_tests/vector-select.ll (right):

https://codereview.chromium.org/417653004/diff/40001/tests_lit/llvm2ice_tests...
tests_lit/llvm2ice_tests/vector-select.ll:1: ; This file test support for the
select instruction with vector valued inputs.
On 2014/07/24 16:40:58, jvoung wrote:
> nit: "tests support"

Done.

Expand Messages | Collapse Messages