Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 417583002: Mojo: Make mojo::Handle::value() return a reference instead of a value. (Closed)

Created:
6 years, 5 months ago by viettrungluu
Modified:
6 years, 5 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Project:
chromium
Visibility:
Public.

Description

Mojo: Make mojo::Handle::value() return a reference instead of a value. Getting the value is fine and fast, but returning a reference has the advantage of allowing you to pass &handle.value() to anything taking a |const MojoHandle*| (without needing to save to a temporary variable). R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285019

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M mojo/public/cpp/system/handle.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
viettrungluu
6 years, 5 months ago (2014-07-23 16:44:21 UTC) #1
sky
LGTM
6 years, 5 months ago (2014-07-23 16:53:20 UTC) #2
viettrungluu
6 years, 5 months ago (2014-07-23 19:51:30 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r285019 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698