content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc - Issue 417573004: indexeddb: Removed use of dangling ptr in writeBlobToFileOnIOThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

Issue 417573004: indexeddb: Removed use of dangling ptr in writeBlobToFileOnIOThread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Including <string> to make "git cl lint" happy Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/indexed_db/indexed_db_backing_store.cc ('K') | « content/browser/indexed_db/indexed_db_backing_store_unittest.cc ('k') | content/browser/indexed_db/indexed_db_context_impl.h » ('j') | content/browser/indexed_db/indexed_db_context_impl.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

diff --git a/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc b/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

index 953d4b4c767c97e7fa88cf8ce21826a6dc65dc8b..b25623bc8e69ccd028ef4e1dc9305417359d3f7e 100644

--- a/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

+++ b/content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc

@@ -102,7 +102,7 @@ TEST(IndexedDBIOErrorTest, CleanUpTest) {

blink::WebIDBDataLoss data_loss = blink::WebIDBDataLossNone;

std::string data_loss_message;

bool disk_full = false;

- base::TaskRunner* task_runner = NULL;

+ base::SequencedTaskRunner* task_runner = NULL;

bool clean_journal = false;

leveldb::Status s;

scoped_refptr<IndexedDBBackingStore> backing_store =

@@ -130,7 +130,7 @@ TEST(IndexedDBNonRecoverableIOErrorTest, NuancedCleanupTest) {

blink::WebIDBDataLossNone;

std::string data_loss_reason;

bool disk_full = false;

- base::TaskRunner* task_runner = NULL;

+ base::SequencedTaskRunner* task_runner = NULL;

bool clean_journal = false;

leveldb::Status s;