content/browser/indexed_db/indexed_db_backing_store_unittest.cc - Issue 417573004: indexeddb: Removed use of dangling ptr in writeBlobToFileOnIOThread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/indexed_db/indexed_db_backing_store_unittest.cc

Issue 417573004: indexeddb: Removed use of dangling ptr in writeBlobToFileOnIOThread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Also scoped LocalWriteClosure::task_runner_ Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/indexed_db/indexed_db_backing_store.cc ('k') | content/browser/indexed_db/indexed_db_cleanup_on_io_error_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/indexed_db/indexed_db_backing_store_unittest.cc

diff --git a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc

index de685b8014e1f4613796c4767d39595550d24958..50a9927e3d94f95b5107053a5ebe0473f0110019 100644

--- a/content/browser/indexed_db/indexed_db_backing_store_unittest.cc

+++ b/content/browser/indexed_db/indexed_db_backing_store_unittest.cc

@@ -9,9 +9,9 @@

#include "base/files/scoped_temp_dir.h"

#include "base/logging.h"

#include "base/macros.h"

+#include "base/sequenced_task_runner.h"

#include "base/strings/string16.h"

#include "base/strings/utf_string_conversions.h"

-#include "base/task_runner.h"

#include "base/test/test_simple_task_runner.h"

#include "content/browser/indexed_db/indexed_db_context_impl.h"

#include "content/browser/indexed_db/indexed_db_factory_impl.h"

@@ -66,7 +66,7 @@ class TestableIndexedDBBackingStore : public IndexedDBBackingStore {

const base::FilePath& path_base,

net::URLRequestContext* request_context,

LevelDBFactory* leveldb_factory,

- base::TaskRunner* task_runner,

+ base::SequencedTaskRunner* task_runner,

leveldb::Status* status) {

DCHECK(!path_base.empty());

@@ -157,7 +157,7 @@ class TestableIndexedDBBackingStore : public IndexedDBBackingStore {

net::URLRequestContext* request_context,

scoped_ptr<LevelDBDatabase> db,

scoped_ptr<LevelDBComparator> comparator,

- base::TaskRunner* task_runner)

+ base::SequencedTaskRunner* task_runner)

: IndexedDBBackingStore(indexed_db_factory,

origin_url,

blob_path,