Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 417503003: Line is falsely set along with border-collapse and colspan.

Created:
6 years, 5 months ago by Gurpreet
Modified:
5 years, 6 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr., rune+blink, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Line is falsely set along with border-collapse and colspan. Incase of collapsed border , adjacent table cells share borders. The table with cell which has border-bottom property set shows border along with cells which doesnot have border since the border has collapsed property. One of the colspan cells share the border-top with other cell's border-bottom and hence border is drawn for all cells. When we draw collapsed borders specially for colspan and rowspan we should take the border property of the cell which has colspan / rowspan else it will take the border property of the adjacent cells. R=jchaffraix@chromium.org,esprehn@chromium.org,eseidel@chromium.org BUG=156823

Patch Set 1 #

Patch Set 2 : Made code changes to consider border color. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -0 lines) Patch
A LayoutTests/fast/table/border-collapsing/border-collapsing-colspan.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/border-collapsing/border-collapsing-colspan-expected-mismatch.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/border-collapsing/border-collapsing-rowspan.html View 1 chunk +27 lines, -0 lines 0 comments Download
A LayoutTests/fast/table/border-collapsing/border-collapsing-rowspan-expected-mismatch.html View 1 chunk +27 lines, -0 lines 0 comments Download
M Source/core/rendering/RenderTableCell.cpp View 1 1 chunk +8 lines, -0 lines 1 comment Download

Messages

Total messages: 6 (0 generated)
Gurpreet
Hi Julien. Please review.
6 years, 5 months ago (2014-07-23 13:27:37 UTC) #1
Gurpreet
Few issues are solved with this patch. For example https://code.google.com/p/chromium/issues/detail?id=394343 https://code.google.com/p/chromium/issues/detail?id=366664 https://code.google.com/p/chromium/issues/detail?id=126118 https://code.google.com/p/chromium/issues/detail?id=356132 colgroup with ...
6 years, 4 months ago (2014-07-28 13:54:11 UTC) #2
Julien - ping for review
https://codereview.chromium.org/417503003/diff/20001/Source/core/rendering/RenderTableCell.cpp File Source/core/rendering/RenderTableCell.cpp (right): https://codereview.chromium.org/417503003/diff/20001/Source/core/rendering/RenderTableCell.cpp#newcode1122 Source/core/rendering/RenderTableCell.cpp:1122: } Overriding our collapsed border here is *not* a ...
6 years, 4 months ago (2014-08-02 00:11:58 UTC) #3
Julien - ping for review
On 2014/08/02 at 00:11:58, Julien Chaffraix - PST wrote: > https://codereview.chromium.org/417503003/diff/20001/Source/core/rendering/RenderTableCell.cpp > File Source/core/rendering/RenderTableCell.cpp (right): ...
6 years, 4 months ago (2014-08-02 00:16:20 UTC) #4
Gurpreet
Thanks Julien for your time and comments.
6 years, 4 months ago (2014-08-06 03:47:07 UTC) #5
Gurpreet
5 years, 6 months ago (2015-06-22 08:36:16 UTC) #6
Currently not working on this issue. If still reproducible on latest and someone
interested to work can take it up.
Thanks.

Powered by Google App Engine
This is Rietveld 408576698