Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(120)

Issue 417493002: Make ui_chromeos_resources IDRs accessible via chrome://theme/<IDR>. (Closed)

Created:
6 years, 5 months ago by Nikita (slow)
Modified:
6 years, 5 months ago
Reviewers:
oshima, sky
CC:
chromium-reviews, stevenjb+watch_chromium.org, oshima+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Make ui_chromeos_resources IDRs accessible via chrome://theme/<IDR>. Same what https://chromiumcodereview.appspot.com/11830002 did for ui_resources. BUG=396209 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285540

Patch Set 1 #

Patch Set 2 : cros only #

Patch Set 3 : +test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+26 lines, -1 line) Patch
M chrome/browser/resources_util.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/resources_util_unittest.cc View 1 2 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +7 lines, -1 line 0 comments Download
M chrome/chrome_tests_unit.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M ui/chromeos/resources/ui_chromeos_resources.grd View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 19 (0 generated)
Nikita (slow)
Hi Oshima and Scott, please take a look. Now that some of Chrome OS resources ...
6 years, 5 months ago (2014-07-23 11:23:07 UTC) #1
Nikita (slow)
Hi Oshima and Scott, please take a look. Now that some of Chrome OS resources ...
6 years, 5 months ago (2014-07-23 11:23:08 UTC) #2
Nikita (slow)
Please take a look. This is a pretty noticeable regression and the fix is straightforward.
6 years, 5 months ago (2014-07-24 08:29:27 UTC) #3
oshima
lgtm
6 years, 5 months ago (2014-07-24 16:38:44 UTC) #4
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-24 17:33:58 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/417493002/40001
6 years, 5 months ago (2014-07-24 17:35:25 UTC) #6
chromium-reviews
Scott, need your lgtm for Missing LGTM from an OWNER for these files: chrome/browser/resources_util.cc chrome/browser/resources_util_unittest.cc ...
6 years, 5 months ago (2014-07-24 18:23:32 UTC) #7
sky
LGTM
6 years, 5 months ago (2014-07-24 19:18:33 UTC) #8
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: chromium_presubmit on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 19:33:07 UTC) #9
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 20:08:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/1995)
6 years, 5 months ago (2014-07-24 20:08:18 UTC) #11
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-24 20:36:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/417493002/40001
6 years, 5 months ago (2014-07-24 20:38:52 UTC) #13
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: linux_chromium_rel_swarming on tryserver.chromium ...
6 years, 5 months ago (2014-07-24 21:12:08 UTC) #14
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 5 months ago (2014-07-24 21:46:04 UTC) #15
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_rel_swarming on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/linux_chromium_rel_swarming/builds/2082)
6 years, 5 months ago (2014-07-24 21:46:05 UTC) #16
Nikita (slow)
The CQ bit was checked by nkostylev@chromium.org
6 years, 5 months ago (2014-07-25 08:41:17 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nkostylev@chromium.org/417493002/40001
6 years, 5 months ago (2014-07-25 08:43:02 UTC) #18
commit-bot: I haz the power
6 years, 5 months ago (2014-07-25 09:19:30 UTC) #19
Message was sent while issue was closed.
Change committed as 285540

Powered by Google App Engine
This is Rietveld 408576698