chrome/browser/ui/global_error/global_error_service_browsertest.cc - Issue 417453002: Disable all the tests that are flaking more than 5% on Linux builders.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/global_error/global_error_service_browsertest.cc

Issue 417453002: Disable all the tests that are flaking more than 5% on Linux builders. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: fix Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ssl/ssl_browser_tests.cc ('K') | « chrome/browser/ssl/ssl_browser_tests.cc ('k') | chrome/browser/ui/panels/docked_panel_browsertest.cc » ('j') | chrome/test/ppapi/ppapi_browsertest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/global_error/global_error_service_browsertest.cc

diff --git a/chrome/browser/ui/global_error/global_error_service_browsertest.cc b/chrome/browser/ui/global_error/global_error_service_browsertest.cc

index ae238311bb3c8e41ff1627d5faef77efbf42b2b5..e9e0d614fb01677a1639489cfd9e80c129c260dd 100644

--- a/chrome/browser/ui/global_error/global_error_service_browsertest.cc

+++ b/chrome/browser/ui/global_error/global_error_service_browsertest.cc

@@ -112,7 +112,7 @@ IN_PROC_BROWSER_TEST_F(GlobalErrorServiceBrowserTest, CloseBubbleView) {

// Test that bubble is silently dismissed if it is showing when the GlobalError

// instance is removed from the profile.

-#if defined(OS_WIN)

+#if defined(OS_WIN) || defined(OS_LINUX)

viettrungluu 2014/07/23 15:26:42 Is there a bug for this?

jam 2014/07/23 16:02:06 Done. forgot to add it

#define MAYBE_BubbleViewDismissedOnRemove DISABLED_BubbleViewDismissedOnRemove

#else

#define MAYBE_BubbleViewDismissedOnRemove BubbleViewDismissedOnRemove