Send responses for any pending 'analysis.getErrors' requests during context removal.

pkg/analysis_server/lib/src/domain_analysis.dart

Index: pkg/analysis_server/lib/src/domain_analysis.dart
diff --git a/pkg/analysis_server/lib/src/domain_analysis.dart b/pkg/analysis_server/lib/src/domain_analysis.dart
index ef166c85819f842d897e30202127a0690a6f139c..de436a98b0dd5324889d0cb00c4acb05c69ff075 100644
--- a/pkg/analysis_server/lib/src/domain_analysis.dart
+++ b/pkg/analysis_server/lib/src/domain_analysis.dart
@@ -47,7 +47,11 @@ class AnalysisDomainHandler implements RequestHandler {
         }).toList());
       }
       server.sendResponse(response);
-    });
+    }).catchError((message) {
+      Response response = new Response.getErrorsError(request, message);
+      response.setResult(ERRORS, []);

[Paul Berry, 2014/07/23 15:06:51]

In this case wouldn't it be more appropriate for the result to be null, since we
couldn't determine what the errors were?

[scheglov, 2014/07/24 16:54:04]

The "errors" field in response is not optional.

+      server.sendResponse(response);
+    }, test: (e) => e is String);

[Paul Berry, 2014/07/23 15:06:51]

This means that in the unlikely event that e is not a string, the response will
never get sent (and we'll have no log messages or assertion failures to help us
debug the problem).

How about something like this instead:

...catchError((message) {
  if (message is! String) {
    AnalysisEngine.instance.logger.logError('Illegal error message during
getErrors: $message');
    message = '';
  }
  Response response = new Response.getErrorsError(request, message);
  ...

[scheglov, 2014/07/24 16:54:04]

Done.

     // delay response
     return Response.DELAYED_RESPONSE;
   }