extensions/browser/api/cast_channel/cast_channel_apitest.cc - Issue 417403002: Remove weak pointers from CastSocket.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/cast_channel/cast_channel_apitest.cc

Issue 417403002: Remove weak pointers from CastSocket. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Respond to Wez comments. Fire callbacks in CloseInternal. Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/browser/api/cast_channel/cast_channel_apitest.cc

diff --git a/extensions/browser/api/cast_channel/cast_channel_apitest.cc b/extensions/browser/api/cast_channel/cast_channel_apitest.cc

index 14f1fbd29a9e806957adcc8fc4cb1047b934987c..92aa958ac2e7aacf17352e84a4ff8b7137b9680e 100644

--- a/extensions/browser/api/cast_channel/cast_channel_apitest.cc

+++ b/extensions/browser/api/cast_channel/cast_channel_apitest.cc

@@ -69,11 +69,6 @@ class MockCastSocket : public CastSocket {

base::TimeDelta::FromMilliseconds(kTimeoutMs)) {}

virtual ~MockCastSocket() {}

- virtual bool CalledOnValidThread() const OVERRIDE {

- // Always return true in testing.

- return true;

- }

MOCK_METHOD1(Connect, void(const net::CompletionCallback& callback));

MOCK_METHOD2(SendMessage, void(const MessageInfo& message,

const net::CompletionCallback& callback));