Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: extensions/browser/api/cast_channel/cast_channel_api.h

Issue 417403002: Remove weak pointers from CastSocket. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update comments. Created 6 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | extensions/browser/api/cast_channel/cast_channel_api.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: extensions/browser/api/cast_channel/cast_channel_api.h
diff --git a/extensions/browser/api/cast_channel/cast_channel_api.h b/extensions/browser/api/cast_channel/cast_channel_api.h
index 99bbb0220ebd709ee65a55bf758f2b7285b92e97..3e077119ba144f101b729c36a928aa3b2a5130d2 100644
--- a/extensions/browser/api/cast_channel/cast_channel_api.h
+++ b/extensions/browser/api/cast_channel/cast_channel_api.h
@@ -98,12 +98,13 @@ class CastChannelAsyncApiFunction : public AsyncApiFunction {
// manager.
void RemoveSocket(int channel_id);
- // Sets the function result to a ChannelInfo obtained from the state of the
- // CastSocket corresponding to |channel_id|.
- void SetResultFromSocket(int channel_id);
+ // Sets the function result to a ChannelInfo obtained from the state of
+ // |socket|.
+ void SetResultFromSocket(const cast_channel::CastSocket& socket);
- // Sets the function result to a ChannelInfo with |error|.
- void SetResultFromError(cast_channel::ChannelError error);
+ // Sets the function result to a ChannelInfo populated with |channel_id| and
+ // |error|.
+ void SetResultFromError(int channel_id, cast_channel::ChannelError error);
// Returns the socket corresponding to |channel_id| if one exists, or null
// otherwise.
« no previous file with comments | « no previous file | extensions/browser/api/cast_channel/cast_channel_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698