Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(45)

Issue 417353004: Use explicit case-insensitive attribute-value matching in UA-stylesheets (Closed)

Created:
6 years, 4 months ago by fs
Modified:
6 years, 4 months ago
CC:
blink-reviews, nessy, blink-reviews-css, gasubic, ed+blinkwatch_opera.com, eric.carlson_apple.com, feature-media-reviews_chromium.org, dglazkov+blink, apavlov+blink_chromium.org, darktears, rune+blink, vcarbune.chromium, rwlbuis, alancutter (OOO until 2018)
Project:
blink
Visibility:
Public.

Description

Use explicit case-insensitive attribute-value matching in UA-stylesheets With the "i" (case-insensitive) matching modifier introduced in https://codereview.chromium.org/330043003/, it becomes possible to refine the hits on the CaseInsensitiveAttrSelectorMatch use-counter by applying the modifier to all rules in the UA-stylesheets which perform an attribute-value match on one of the attributes that - due to legacy reasons - should be matched case-insensitively. Most of the modified rules involve the 'type' attribute on <input> elements, but there are a few others as well ('dir' and 'align'). The goal of this is to be able to get rid of the legacy-induced case- insensitive cases and leave the "i" flag as a mechanism to opt-in to case-insensitive matching. See https://crbug.com/327060 for further info. BUG=327060, 366563 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179401

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+122 lines, -122 lines) Patch
M Source/core/css/html.css View 19 chunks +58 lines, -58 lines 0 comments Download
M Source/core/css/mediaControls.css View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/quirks.css View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/css/themeChromiumAndroid.css View 1 chunk +15 lines, -15 lines 0 comments Download
M Source/core/css/themeChromiumLinux.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/themeInputMultipleFields.css View 2 chunks +11 lines, -11 lines 0 comments Download
M Source/core/css/themeMac.css View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/css/themeWin.css View 2 chunks +30 lines, -30 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
fs
This is a mechanical change. The intention is to get a better idea of how ...
6 years, 4 months ago (2014-08-01 13:41:42 UTC) #1
Mike West
LGTM. I see you added it to the BUG line, but can you add an ...
6 years, 4 months ago (2014-08-01 14:04:35 UTC) #2
fs
On 2014/08/01 14:04:35, Mike West wrote: > LGTM. > > I see you added it ...
6 years, 4 months ago (2014-08-01 14:29:04 UTC) #3
fs
The CQ bit was checked by fs@opera.com
6 years, 4 months ago (2014-08-01 14:29:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/fs@opera.com/417353004/1
6 years, 4 months ago (2014-08-01 14:29:58 UTC) #5
commit-bot: I haz the power
Change committed as 179401
6 years, 4 months ago (2014-08-01 14:35:18 UTC) #6
eseidel
I'm confused by what the goal is here? We can also disable UseCounters while parsing ...
6 years, 4 months ago (2014-08-01 16:35:43 UTC) #7
philipj_slow
6 years, 4 months ago (2014-08-02 04:56:23 UTC) #8
Message was sent while issue was closed.
Selector matching happens after parsing, I guess that's why.

Powered by Google App Engine
This is Rietveld 408576698