Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(9)

Issue 417353002: Fix a potential overflow in BinarySearch, same as Issue 344513004 (Closed)

Created:
6 years, 5 months ago by jianghua
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://github.com/v8/v8.git@master
Project:
v8
Visibility:
Public.

Description

Fix a potential overflow in BinarySearch, same as Issue 344513004 BUG=

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/objects-inl.h View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jianghua
please review .
6 years, 5 months ago (2014-07-26 01:43:22 UTC) #1
jochen (gone - plz use gerrit)
On 2014/07/26 at 01:43:22, jianghua.yjh wrote: > please review . I couldn't find a CCLA ...
6 years, 4 months ago (2014-07-28 09:06:49 UTC) #2
jianghua
On 2014/07/28 09:06:49, jochen (ooo) wrote: > On 2014/07/26 at 01:43:22, jianghua.yjh wrote: > > ...
5 years, 3 months ago (2015-09-01 09:54:00 UTC) #3
jochen (gone - plz use gerrit)
lgtm
5 years, 3 months ago (2015-09-08 12:24:39 UTC) #4
jianghua
5 years, 3 months ago (2015-09-08 13:17:34 UTC) #5
On 2015/09/08 12:24:39, jochen wrote:
> lgtm

please land it for me , https://codereview.chromium.org/1314253006/

Powered by Google App Engine
This is Rietveld 408576698