Don't capture screenshots for in-page navigations.

content/browser/web_contents/aura/image_window_delegate.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/web_contents/aura/image_window_delegate.h"
 
 #include "ui/base/cursor/cursor.h"
 #include "ui/base/hit_test.h"
 #include "ui/compositor/compositor.h"
 #include "ui/gfx/canvas.h"
@@ skipping 48 matching lines @@
 
 bool ImageWindowDelegate::CanFocus() {
   return false;
 }
 
 void ImageWindowDelegate::OnCaptureLost() {
 }
 
 void ImageWindowDelegate::OnPaint(gfx::Canvas* canvas) {
   if (image_.IsEmpty()) {
-    canvas->DrawColor(SK_ColorGRAY);
+    canvas->DrawColor(SK_ColorWHITE);

[sky, 2014/07/25 22:08:06]

Why are we changing colors?

[mfomitchev, 2014/07/25 22:29:15]

Kuscher asked for this. Testing it out, I agree with him that it does look
better with white for GMail, which is our main concern here.

[sky, 2014/07/25 22:44:49]

Won't this impact *all* sites though? And won't it impact windows? My main
concern here is your desire to merge to 37. I'm fine with landing this on trunk,
but I'm not so happy about the desire to merge to 37 until this shakes out for a
while. How about separating the two patches out?

[mfomitchev, 2014/07/25 23:09:58]

Yes it would. I think it would look better for any site that uses white
background. It would look worse for sites that use gray background. For other
sites I don't think it would make a difference. And there's more sites that use
white background than gray background...
What's your concern with using the white background? 

Either way, I will separate the background patch out.

   } else {
     if (size_mismatch_)
       canvas->DrawColor(SK_ColorWHITE);
     canvas->DrawImageInt(image_.AsImageSkia(), 0, 0);
   }
 }
 
 void ImageWindowDelegate::OnDeviceScaleFactorChanged(float scale_factor) {
 }
 
 void ImageWindowDelegate::OnWindowDestroying(aura::Window* window) {
 }
 
 void ImageWindowDelegate::OnWindowDestroyed(aura::Window* window) {
   delete this;
 }
 
 void ImageWindowDelegate::OnWindowTargetVisibilityChanged(bool visible) {
 }
 
 bool ImageWindowDelegate::HasHitTestMask() const {
   return false;
 }
 
 void ImageWindowDelegate::GetHitTestMask(gfx::Path* mask) const {
 }
 
 }  // namespace content