Source/testing/runner/TestInterfaces.cpp - Issue 41733004: Roll up patch for running layout tests under Aura.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/testing/runner/TestInterfaces.cpp

Issue 41733004: Roll up patch for running layout tests under Aura. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: add even more comments about why we have special logic for the layout tests Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/testing/runner/TestInterfaces.cpp

diff --git a/Source/testing/runner/TestInterfaces.cpp b/Source/testing/runner/TestInterfaces.cpp

index 8756149b2e5edb50b4f60bca4d900136d0569188..e218e1e404ab86948e89269026fdbd9529e66dbe 100644

--- a/Source/testing/runner/TestInterfaces.cpp

+++ b/Source/testing/runner/TestInterfaces.cpp

@@ -196,8 +196,10 @@ const vector<WebTestProxyBase*>& TestInterfaces::windowList()

WebThemeEngine* TestInterfaces::themeEngine()

{

-#if defined(USE_DEFAULT_RENDER_THEME) || !(defined(WIN32) || defined(__APPLE__))

- return 0;

+#if defined(USE_DEFAULT_RENDER_THEME)

+ if (!m_themeEngine.get())

+ m_themeEngine.reset(new WebTestThemeEngineMock());

+ return m_themeEngine.get();

#elif defined(WIN32)

if (!m_themeEngine.get())

m_themeEngine.reset(new WebTestThemeEngineWin());

@@ -206,6 +208,8 @@ WebThemeEngine* TestInterfaces::themeEngine()

if (!m_themeEngine.get())

m_themeEngine.reset(new WebTestThemeEngineMac());

return m_themeEngine.get();

+#else

+ return 0;

#endif

}