Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(85)

Side by Side Diff: mojo/system/core_unittest.cc

Issue 417303002: Convert ReadMessage...() to use the new user pointer handling (see r285350). (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: hmm Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « mojo/system/core_test_base.cc ('k') | mojo/system/dispatcher.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "mojo/system/core.h" 5 #include "mojo/system/core.h"
6 6
7 #include <limits> 7 #include <limits>
8 8
9 #include "base/basictypes.h" 9 #include "base/basictypes.h"
10 #include "base/threading/platform_thread.h" 10 #include "base/threading/platform_thread.h"
(...skipping 36 matching lines...) Expand 10 before | Expand all | Expand 10 after
47 EXPECT_EQ(2u, info.GetWriteMessageCallCount()); 47 EXPECT_EQ(2u, info.GetWriteMessageCallCount());
48 48
49 EXPECT_EQ(0u, info.GetReadMessageCallCount()); 49 EXPECT_EQ(0u, info.GetReadMessageCallCount());
50 uint32_t num_bytes = 0; 50 uint32_t num_bytes = 0;
51 EXPECT_EQ(MOJO_RESULT_OK, 51 EXPECT_EQ(MOJO_RESULT_OK,
52 core()->ReadMessage(h, NullUserPointer(), 52 core()->ReadMessage(h, NullUserPointer(),
53 MakeUserPointer(&num_bytes), NullUserPointer(), 53 MakeUserPointer(&num_bytes), NullUserPointer(),
54 NullUserPointer(), 54 NullUserPointer(),
55 MOJO_READ_MESSAGE_FLAG_NONE)); 55 MOJO_READ_MESSAGE_FLAG_NONE));
56 EXPECT_EQ(1u, info.GetReadMessageCallCount()); 56 EXPECT_EQ(1u, info.GetReadMessageCallCount());
57 num_bytes = 1;
58 EXPECT_EQ(MOJO_RESULT_INVALID_ARGUMENT,
59 core()->ReadMessage(h, NullUserPointer(),
60 MakeUserPointer(&num_bytes), NullUserPointer(),
61 NullUserPointer(),
62 MOJO_READ_MESSAGE_FLAG_NONE));
63 EXPECT_EQ(2u, info.GetReadMessageCallCount());
64 EXPECT_EQ(MOJO_RESULT_OK, 57 EXPECT_EQ(MOJO_RESULT_OK,
65 core()->ReadMessage(h, NullUserPointer(), NullUserPointer(), 58 core()->ReadMessage(h, NullUserPointer(), NullUserPointer(),
66 NullUserPointer(), NullUserPointer(), 59 NullUserPointer(), NullUserPointer(),
67 MOJO_READ_MESSAGE_FLAG_NONE)); 60 MOJO_READ_MESSAGE_FLAG_NONE));
68 EXPECT_EQ(3u, info.GetReadMessageCallCount()); 61 EXPECT_EQ(2u, info.GetReadMessageCallCount());
69 62
70 EXPECT_EQ(0u, info.GetWriteDataCallCount()); 63 EXPECT_EQ(0u, info.GetWriteDataCallCount());
71 EXPECT_EQ(MOJO_RESULT_UNIMPLEMENTED, 64 EXPECT_EQ(MOJO_RESULT_UNIMPLEMENTED,
72 core()->WriteData(h, NullUserPointer(), NullUserPointer(), 65 core()->WriteData(h, NullUserPointer(), NullUserPointer(),
73 MOJO_WRITE_DATA_FLAG_NONE)); 66 MOJO_WRITE_DATA_FLAG_NONE));
74 EXPECT_EQ(1u, info.GetWriteDataCallCount()); 67 EXPECT_EQ(1u, info.GetWriteDataCallCount());
75 68
76 EXPECT_EQ(0u, info.GetBeginWriteDataCallCount()); 69 EXPECT_EQ(0u, info.GetBeginWriteDataCallCount());
77 EXPECT_EQ(MOJO_RESULT_UNIMPLEMENTED, 70 EXPECT_EQ(MOJO_RESULT_UNIMPLEMENTED,
78 core()->BeginWriteData(h, NullUserPointer(), NullUserPointer(), 71 core()->BeginWriteData(h, NullUserPointer(), NullUserPointer(),
(...skipping 921 matching lines...) Expand 10 before | Expand all | Expand 10 after
1000 EXPECT_EQ(MOJO_RESULT_OK, core()->Close(h_passing[1])); 993 EXPECT_EQ(MOJO_RESULT_OK, core()->Close(h_passing[1]));
1001 EXPECT_EQ(MOJO_RESULT_OK, core()->Close(ph)); 994 EXPECT_EQ(MOJO_RESULT_OK, core()->Close(ph));
1002 EXPECT_EQ(MOJO_RESULT_OK, core()->Close(ch)); 995 EXPECT_EQ(MOJO_RESULT_OK, core()->Close(ch));
1003 } 996 }
1004 997
1005 // TODO(vtl): Test |DuplicateBufferHandle()| and |MapBuffer()|. 998 // TODO(vtl): Test |DuplicateBufferHandle()| and |MapBuffer()|.
1006 999
1007 } // namespace 1000 } // namespace
1008 } // namespace system 1001 } // namespace system
1009 } // namespace mojo 1002 } // namespace mojo
OLDNEW
« no previous file with comments | « mojo/system/core_test_base.cc ('k') | mojo/system/dispatcher.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698