Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1785)

Unified Diff: core/include/fxcrt/fx_system.h

Issue 417263008: Correct the names of the FX_SAFE_* typedefs. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master
Patch Set: Created 6 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: core/include/fxcrt/fx_system.h
diff --git a/core/include/fxcrt/fx_system.h b/core/include/fxcrt/fx_system.h
index 391380304c936a302a77d2d5fef41e3110687e8e..fe54e5ce82d24de1a2f9451247bc700dd51dd04b 100644
--- a/core/include/fxcrt/fx_system.h
+++ b/core/include/fxcrt/fx_system.h
@@ -278,7 +278,7 @@ int FXSYS_round(FX_FLOAT f);
#include "../../../third_party/numerics/safe_math.h"
typedef base::CheckedNumeric<FX_DWORD> FX_SAFE_DWORD;
jun_fang 2014/07/31 18:58:41 Can we raise one issue to change previous safe-che
palmer 2014/07/31 19:05:03 Acknowledged.
-typedef base::CheckedNumeric<FX_INT32> FX_SAFE_INT;
+typedef base::CheckedNumeric<FX_INT32> FX_SAFE_INT32;
jun_fang 2014/07/31 18:58:40 It's not aligned with FX_SAFE_DWORD and FX_SAFE_SI
palmer 2014/07/31 19:05:03 Fixed. (This is why it's a good idea to always us
typedef base::CheckedNumeric<size_t> FX_SAFE_SIZET;
Tom Sepez 2014/07/31 18:58:38 While yer at it, make this one FX_SAFE_SIZE_T. Pe
jun_fang 2014/07/31 18:58:41 Tom suggests to change FX_SAFE_SIZET to FX_SAFE_SI
palmer 2014/07/31 19:05:03 Done.
palmer 2014/07/31 19:05:03 Done.
#if defined(__clang__) || _MSC_VER >= 1700
#define FX_FINAL final
« no previous file with comments | « no previous file | core/src/fpdfapi/fpdf_render/fpdf_render_loadimage.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698