Correct the names of the FX_SAFE_* typedefs.

Correct the names of the FX_SAFE_* typedefs.

R=jun_fang@foxitsoftware.com

Committed: https://pdfium.googlesource.com/pdfium/+/515c26b

[palmer, 2014-07-31 18:52:22]

A minor fix in naming.

[Tom Sepez, 2014-07-31 18:58:39]

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system.h
File core/include/fxcrt/fx_system.h (right):

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
core/include/fxcrt/fx_system.h:282: typedef base::CheckedNumeric<size_t>        
   FX_SAFE_SIZET;
While yer at it, make this one FX_SAFE_SIZE_T.  Per my comment in
https://codereview.chromium.org/419063002/, if someone were to invent a type
sizet distinct from size_t and try to use it with FX_SAFE_SIZET ...

[jun_fang, 2014-07-31 18:58:41]

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system.h
File core/include/fxcrt/fx_system.h (right):

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
core/include/fxcrt/fx_system.h:280: typedef base::CheckedNumeric<FX_DWORD>
		FX_SAFE_DWORD;
Can we raise one issue to change previous safe-check to use these common safe
variables? We don't need to include "../../../third_party/numerics/safe_math.h"
everywhere if we use these common safe variables.

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
core/include/fxcrt/fx_system.h:281: typedef base::CheckedNumeric<FX_INT32>
		FX_SAFE_INT32;
It's not aligned with FX_SAFE_DWORD and FX_SAFE_SIZET. Remove one blank?

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
core/include/fxcrt/fx_system.h:282: typedef base::CheckedNumeric<size_t>        
   FX_SAFE_SIZET;
Tom suggests to change FX_SAFE_SIZET to FX_SAFE_SIZE_T.

[palmer, 2014-07-31 19:05:03]

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system.h
File core/include/fxcrt/fx_system.h (right):

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
core/include/fxcrt/fx_system.h:280: typedef base::CheckedNumeric<FX_DWORD>
		FX_SAFE_DWORD;
On 2014/07/31 18:58:41, jun_fang wrote:
> Can we raise one issue to change previous safe-check to use these common safe
> variables? We don't need to include
"../../../third_party/numerics/safe_math.h"
> everywhere if we use these common safe variables.

Acknowledged.

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
core/include/fxcrt/fx_system.h:281: typedef base::CheckedNumeric<FX_INT32>
		FX_SAFE_INT32;
> It's not aligned with FX_SAFE_DWORD and FX_SAFE_SIZET. Remove one blank?

Fixed.

(This is why it's a good idea to always uses spaces instead of tabs.)

(Someday we'll want to run all this code through clang-format.)

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
core/include/fxcrt/fx_system.h:282: typedef base::CheckedNumeric<size_t>        
   FX_SAFE_SIZET;
On 2014/07/31 18:58:41, jun_fang wrote:
> Tom suggests to change FX_SAFE_SIZET to FX_SAFE_SIZE_T. 

Done.

https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
core/include/fxcrt/fx_system.h:282: typedef base::CheckedNumeric<size_t>        
   FX_SAFE_SIZET;
On 2014/07/31 18:58:38, Tom Sepez wrote:
> While yer at it, make this one FX_SAFE_SIZE_T.  Per my comment in
> https://codereview.chromium.org/419063002/, if someone were to invent a type
> sizet distinct from size_t and try to use it with FX_SAFE_SIZET ... 

Done.

[jun_fang, 2014-07-31 19:08:18]

On 2014/07/31 19:05:03, Chromium Palmer wrote:
>
https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system.h
> File core/include/fxcrt/fx_system.h (right):
> 
>
https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
> core/include/fxcrt/fx_system.h:280: typedef base::CheckedNumeric<FX_DWORD>
> 		FX_SAFE_DWORD;
> On 2014/07/31 18:58:41, jun_fang wrote:
> > Can we raise one issue to change previous safe-check to use these common
safe
> > variables? We don't need to include
> "../../../third_party/numerics/safe_math.h"
> > everywhere if we use these common safe variables.
> 
> Acknowledged.
> 
>
https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
> core/include/fxcrt/fx_system.h:281: typedef base::CheckedNumeric<FX_INT32>
> 		FX_SAFE_INT32;
> > It's not aligned with FX_SAFE_DWORD and FX_SAFE_SIZET. Remove one blank?
> 
> Fixed.
> 
> (This is why it's a good idea to always uses spaces instead of tabs.)
> 
> (Someday we'll want to run all this code through clang-format.)
> 
>
https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
> core/include/fxcrt/fx_system.h:282: typedef base::CheckedNumeric<size_t>      
 
>    FX_SAFE_SIZET;
> On 2014/07/31 18:58:41, jun_fang wrote:
> > Tom suggests to change FX_SAFE_SIZET to FX_SAFE_SIZE_T. 
> 
> Done.
> 
>
https://codereview.chromium.org/417263008/diff/1/core/include/fxcrt/fx_system...
> core/include/fxcrt/fx_system.h:282: typedef base::CheckedNumeric<size_t>      
 
>    FX_SAFE_SIZET;
> On 2014/07/31 18:58:38, Tom Sepez wrote:
> > While yer at it, make this one FX_SAFE_SIZE_T.  Per my comment in
> > https://codereview.chromium.org/419063002/, if someone were to invent a type
> > sizet distinct from size_t and try to use it with FX_SAFE_SIZET ... 
> 
> Done.

LGTM

[palmer, 2014-07-31 19:09:00]

Committed patchset #2 manually as r515c26b (presubmit successful).