content/public/android/java/src/org/chromium/content/browser/DownloadController.java - Issue 417263004: Chrome Android PDF Downloads: Pass in HasUserGesture param to Java side.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/android/java/src/org/chromium/content/browser/DownloadController.java

Issue 417263004: Chrome Android PDF Downloads: Pass in HasUserGesture param to Java side. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/browser/android/download_controller_android_impl.cc ('K') | « content/browser/android/download_controller_android_impl.cc ('k') | content/public/android/java/src/org/chromium/content/browser/DownloadInfo.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/android/java/src/org/chromium/content/browser/DownloadController.java

diff --git a/content/public/android/java/src/org/chromium/content/browser/DownloadController.java b/content/public/android/java/src/org/chromium/content/browser/DownloadController.java

index e7c8710709aa5cd7ba0cdedc40a5e11ad552e089..b0cab89b8937497296f586598d167f95a728380a 100644

--- a/content/public/android/java/src/org/chromium/content/browser/DownloadController.java

+++ b/content/public/android/java/src/org/chromium/content/browser/DownloadController.java

@@ -64,7 +64,8 @@ public class DownloadController {

@CalledByNative

public void newHttpGetDownload(ContentViewCore view, String url,

String userAgent, String contentDisposition, String mimeType,

- String cookie, String referer, String filename, long contentLength) {

+ String cookie, String referer, boolean hasUserGesture,

+ String filename, long contentLength) {

ContentViewDownloadDelegate downloadDelegate = downloadDelegateFromView(view);

if (downloadDelegate != null) {

@@ -75,6 +76,7 @@ public class DownloadController {

.setMimeType(mimeType)

.setCookie(cookie)

.setReferer(referer)

+ .setHasUserGesture(hasUserGesture)

.setFileName(filename)

.setContentLength(contentLength)

.setIsGETRequest(true)