Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 417253003: Make CPU profiler function names match ones from StackFrame iterator. (Closed)

Created:
6 years, 4 months ago by alph
Modified:
6 years, 4 months ago
Reviewers:
yurys, Yang, loislo
CC:
v8-dev
Project:
v8
Visibility:
Public.

Description

Make CPU profiler function names match ones from StackFrame iterator. R=yangguo@chromium.org, yurys@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=22845

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressing comment. #

Patch Set 3 : Rebaseline #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -26 lines) Patch
M src/cpu-profiler.h View 1 1 chunk +5 lines, -8 lines 0 comments Download
M src/cpu-profiler.cc View 1 2 2 chunks +10 lines, -14 lines 0 comments Download
M src/isolate.cc View 1 2 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
alph
6 years, 4 months ago (2014-07-29 20:13:29 UTC) #1
yurys
lgtm https://codereview.chromium.org/417253003/diff/1/src/cpu-profiler.cc File src/cpu-profiler.cc (right): https://codereview.chromium.org/417253003/diff/1/src/cpu-profiler.cc#newcode229 src/cpu-profiler.cc:229: Name* name) { Could you rename the argument ...
6 years, 4 months ago (2014-07-30 07:43:49 UTC) #2
alph
Yang, could you please take a look. https://codereview.chromium.org/417253003/diff/1/src/cpu-profiler.cc File src/cpu-profiler.cc (right): https://codereview.chromium.org/417253003/diff/1/src/cpu-profiler.cc#newcode229 src/cpu-profiler.cc:229: Name* name) ...
6 years, 4 months ago (2014-07-30 09:12:58 UTC) #3
Yang
On 2014/07/30 09:12:58, alph wrote: > Yang, could you please take a look. > > ...
6 years, 4 months ago (2014-07-30 13:45:54 UTC) #4
alph
6 years, 4 months ago (2014-08-05 07:31:26 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 manually as 22845 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698