Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 417233002: NaCl: Update revision in DEPS, r13506 -> r13528 (Closed)

Created:
6 years, 5 months ago by Mark Seaborn
Modified:
6 years, 5 months ago
Reviewers:
bradn
CC:
chromium-reviews, binji, bradn, Derek Schuff, David Yen, hidehiko, jvoung - send to chromium..., native-client-reviews_googlegroups.com, Nick Bray (chromium), noelallen_use_chromium, Sam Clegg, teravest
Project:
chromium
Visibility:
Public.

Description

NaCl: Update revision in DEPS, r13506 -> r13528 This pulls in the following Native Client changes: r13507: (noelallen) Reapply patch which was reverted due to conflict. r13508: (dschuff) PNaCl Driver: do not generate temp file names beyond Windows' MAX_PATH limit r13509: (jvoung) Add a flag to pnacl-finalize that allows users to keep function names. r13510: (dschuff) Disable flaky sandboxed translator tests on mac r13511: (dschuff) Update revision for PNaCl r13466->r13509 r13512: (ncbray) Fix untrusted.gypi and build_nexe.py r13513: (noelallen) Cleanup bionic build script. r13514: (dyen) Added initial pass of nacl_irt_code_data_alloc. r13515: (sbc) Use custom exception class for errors in package_version. r13516: (hidehiko) Non-SFI mode: SCONS_NONSFI_TC clean up. r13517: (hidehiko) Non-SFI Mode: Refactoring. Provide non-SFI version of nacl_irt_query_core. r13518: (binji) Revert "Non-SFI mode: SCONS_NONSFI_TC clean up." r13519: (bradnelson) Make the trybots fail early if 'git cl try' is mistakenly used. r13520: (bradnelson) Make build_nexe.py rebuild when script itself has changed. r13521: (noelallen) Updates GN dep, and cleans up some toolchain prep definitions to make it easier to debug what's going on. r13523: (teravest) Add embedder interface for fatal log messages. r13524: (bradnelson) Passing --config-name to build_nexe.py for all arches. r13525: (teravest) Create a sel_ldr_launcher_base target. r13526: (teravest) Revert "Add embedder interface for fatal log messages." r13527: (hidehiko) Non-SFI mode: Get rid of socketcall on ARM. r13528: (teravest) Add embedder interface for fatal log messages. BUG=none TEST=browser_tests and nacl_integration CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_nacl_sdk_build TBR=bradnelson@google.com Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285812

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M DEPS View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Mark Seaborn
6 years, 5 months ago (2014-07-26 18:39:58 UTC) #1
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 5 months ago (2014-07-26 18:40:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/417233002/1
6 years, 5 months ago (2014-07-26 18:40:47 UTC) #3
commit-bot: I haz the power
Change committed as 285812
6 years, 5 months ago (2014-07-26 21:27:05 UTC) #4
Mark Seaborn
6 years, 5 months ago (2014-07-26 22:01:24 UTC) #5
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/419373002/ by mseaborn@chromium.org.

The reason for reverting is: This failed on the "Win x64 Builder (dbg)" buildbot
due to long filename issues.

I rolled a too-old revision of NaCl that didn't include Jan's revert of r13511
(which switches the PNaCl toolchain from Cygwin to MinGW)..

Powered by Google App Engine
This is Rietveld 408576698