Introduce PlatformEvent to handle Device events, Battery events and Gamepad events.

Introduce PlatformEvent to handle Device events, Battery events and Gamepad events.

BUG=None

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=179596

[abarth-chromium, 2014-07-29 22:24:38]

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform...
public/platform/Platform.h:604: virtual void
startListening(blink::WebPlatformEventType type,
blink::WebPlatformEventListener* listener)
Why virtual?

It seems like we should implement this function in Source/platform rather than
in Platform.h.  The function here are mostly just stubs.

[mlamouri (slow - plz ping), 2014-07-29 22:27:54]

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform...
public/platform/Platform.h:604: virtual void
startListening(blink::WebPlatformEventType type,
blink::WebPlatformEventListener* listener)
On 2014/07/29 22:24:38, abarth wrote:
> Why virtual?
> 
> It seems like we should implement this function in Source/platform rather than
> in Platform.h.  The function here are mostly just stubs.

The only intent is to not break Chromium when this land. content/ would then
implement startListening() and stopListening() and we will be able to remove
those. If you prefer that temporary code to live in another place, I could do
that. What would be the best place?

[abarth-chromium, 2014-07-30 05:55:28]

On 2014/07/29 at 22:27:54, mlamouri wrote:
> The only intent is to not break Chromium when this land. content/ would then
implement startListening() and stopListening() and we will be able to remove
those. If you prefer that temporary code to live in another place, I could do
that. What would be the best place?

Oh, that wasn't clear to me.  We should probably include a comment explaining
that.

[abarth-chromium, 2014-07-30 05:56:23]

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform...
public/platform/Platform.h:648: // Deprecated: remove when content/ is updated.
I see, this comment was intended to communicate that information.

[abarth-chromium, 2014-07-30 05:58:43]

Ok, LGTM

[timvolodine, 2014-07-30 12:56:41]

lgtm, looking forward to further cleanups :)

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform...
public/platform/Platform.h:602: // Request the platform to start listening to
the specified event and
nit: "to the specified event" -> "to events of specified type"?
also in stopListening()

[mlamouri (slow - plz ping), 2014-08-01 10:21:05]

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform.h
File public/platform/Platform.h (right):

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform...
public/platform/Platform.h:602: // Request the platform to start listening to
the specified event and
On 2014/07/30 12:56:41, timvolodine wrote:
> nit: "to the specified event" -> "to events of specified type"?
> also in stopListening()

Done.

https://codereview.chromium.org/417213002/diff/40001/public/platform/Platform...
public/platform/Platform.h:648: // Deprecated: remove when content/ is updated.
On 2014/07/30 05:56:23, abarth wrote:
> I see, this comment was intended to communicate that information.

Yes. I've added a FIXME to make it clearer.

[mlamouri (slow - plz ping), 2014-08-05 20:13:31]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-08-05 20:16:03]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/417213002/80001

[commit-bot: I haz the power, 2014-08-06 00:09:42]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_chromium_gn_compile_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/android_chromium_gn_comp...)
  linux_blink_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_dbg/builds/1...)
  linux_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/1...)
  win_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_compile_dbg/bu...)
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21112)

[commit-bot: I haz the power, 2014-08-06 00:48:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-08-06 00:48:42]

Try jobs failed on following builders:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21175)

[mlamouri (slow - plz ping), 2014-08-06 07:53:19]

The CQ bit was checked by mlamouri@chromium.org

[commit-bot: I haz the power, 2014-08-06 07:55:29]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/mlamouri@chromium.org/417213002/80001

[commit-bot: I haz the power, 2014-08-06 08:57:05]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  win_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/21291)

[commit-bot: I haz the power, 2014-08-06 10:04:27]

Change committed as 179596