Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Issue 417203002: Add browser test to connect chormium sink to remote tracks, verify that no crash. (Closed)

Created:
6 years, 5 months ago by no longer working on chromium
Modified:
6 years, 4 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, jam, darin-cc_chromium.org
Project:
chromium
Visibility:
Public.

Description

Add browser test to connect chormium sink to remote tracks, verify that no crash. BUG=396447 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=285808

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -0 lines) Patch
M content/browser/media/webrtc_browsertest.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M content/test/data/media/peerconnection-call.html View 1 chunk +24 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
no longer working on chromium
Ronghua, this is a follow up to crbug/396447 to add browser test to protect regression, ...
6 years, 5 months ago (2014-07-25 14:39:30 UTC) #1
Ronghua Wu (Left Chromium)
LGTM I thought there is another crash when you try to add that mediastream to ...
6 years, 5 months ago (2014-07-25 17:24:20 UTC) #2
no longer working on chromium
On 2014/07/25 17:24:20, Ronghua Wu wrote: > LGTM > > I thought there is another ...
6 years, 5 months ago (2014-07-26 18:59:25 UTC) #3
no longer working on chromium
The CQ bit was checked by xians@chromium.org
6 years, 5 months ago (2014-07-26 18:59:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/417203002/20001
6 years, 5 months ago (2014-07-26 19:00:50 UTC) #5
commit-bot: I haz the power
Change committed as 285808
6 years, 5 months ago (2014-07-26 20:25:19 UTC) #6
Ronghua Wu (Left Chromium)
6 years, 4 months ago (2014-07-28 15:28:45 UTC) #7
Message was sent while issue was closed.
On 2014/07/26 18:59:25, xians1 wrote:
> On 2014/07/25 17:24:20, Ronghua Wu wrote:
> > LGTM
> > 
> > I thought there is another crash when you try to add that mediastream to a
> > peerconnection. Do we need test for that as well?
> 
> Right, I agree that we probably should add a test for adding the same track to
a
> peerconnection more than once.
> I just did not have time to wire it up on Friday.
> 
> I am going to create a new issue to assign it to Patrik for the new test.
> 
> Hope it is fine.

Sure, thanks.

Powered by Google App Engine
This is Rietveld 408576698