src/log.cc - Issue 4172006: Merge r5721 into 2.4 branch. Suppress reporting of nested DOM calls in CPU pr...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/log.cc

Issue 4172006: Merge r5721 into 2.4 branch. Suppress reporting of nested DOM calls in CPU pr... (Closed) Base URL: http://v8.googlecode.com/svn/branches/2.4/

Patch Set: Created 10 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/log.cc

===================================================================

--- src/log.cc (revision 5724)

+++ src/log.cc (working copy)

@@ -164,7 +164,10 @@

int i = 0;

const Address callback = VMState::external_callback();

- if (callback != NULL) {

+ // Surprisingly, PC can point _exactly_ to callback start, with good

+ // probability, and this will result in reporting fake nested

+ // callback call.

+ if (callback != NULL && callback != sample->pc) {

sample->stack[i++] = callback;

}

« no previous file with comments | « no previous file | src/version.cc » ('j') | no next file with comments »